App provider: fallback to env. variable if 'iopsecret' unset #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
SamuAlfageme
force-pushed
the
appprovider_iopsecret
branch
from
6d9cece
to
e45395c
Compare
ishank011
approved these changes
Sep 8, 2020
SamuAlfageme
added a commit
to SamuAlfageme/reva
that referenced
this pull request
Sep 15, 2020
SamuAlfageme
added a commit
to SamuAlfageme/reva
that referenced
this pull request
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to open this PR a while back. Giving it a second though, we should review all the parameters in the config that refer to passwords/secrets and provide a fallback to environment variables in case they are not present.
Thoughts? cc/ @labkode @ishank011