Fix OS storage move propagation #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the propagate function in OC storage was not properly catching errors.
|
=> this makes the litmus webdav move tests pass! |
labkode
approved these changes
May 8, 2020
|
@PVince81 just lint and is good to merge |
Propagating on the source path failed because the source path does not exist any more after moving. This fix makes it start the propagation on the parent of the source.
|
I've removed the stray debug code and fixed the linter errors by properly returning the error objects. |
|
all green, please merge :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagating on the source path failed because the source path does not exist any more after moving. This fix makes it start the propagation on the parent of the source.
I've also fixed the error handling because while debugging this it caused memory pointer errors as the errors were not propagated to the outside.
@butonic