ocdav: Adjust propstat response for removed properties

[PVince81]

Removed properties now appear in a propstat block with status 204.
The list of properties appearing in propstat blocks now depend on the
request and no more on the values returned by the Stat call.

This fixes the propdeletes and popreplace test cases from Litmus.

Former result is owncloud/ocis-reva#183
Current result after the fix:

docker run -e LITMUS_URL="http://172.17.0.1:9140/remote.php/webdav" -e LITMUS_USERNAME="einstein" -e LITMUS_PASSWORD="relativity" -e TESTS="props" owncloud/litmus:latest
-> running `props':
 0. init.................. pass
 1. begin................. pass
 2. propfind_invalid...... pass
 3. propfind_invalid2..... pass
 4. propfind_d0........... pass
 5. propinit.............. pass
 6. propset............... pass
 7. propget............... pass
 8. propextended.......... pass
 9. propmove.............. pass
10. propget............... pass
11. propdeletes........... pass
12. propget............... pass
13. propreplace........... pass
14. propget............... pass
15. propnullns............ pass
16. propget............... pass
17. propremoveset......... pass
18. propget............... pass
19. propsetremove......... pass
20. propget............... FAIL (Deleted property `{http://example.com/neon/litmus/}removeset' was still present)
21. propvalnspace......... pass
22. propwformed........... FAIL (PROPFIND on `/remote.php/webdav/litmus/prop2': 207 Multi-Status)
23. propinit.............. pass
24. propmanyns............ pass
25. propget............... pass
26. propcleanup........... pass
27. finish................ pass
<- summary for `props': of 28 tests run: 26 passed, 2 failed. 92.9%
See debug.log for network/debug traces.

Next up I'll look into those additional issues.

[PVince81]

oh... it seems that the "removeset" case is actually testing whether the proppatch operations were applied in order, it first sets a property and removes it directly within the same call...

I had added a FIXME for this in the PR but will now address this directly...

[PVince81]

okay, now processing in correct order. it fixes the "propsetremove" issue.

only one remains:

docker run -e LITMUS_URL="http://172.17.0.1:9140/remote.php/webdav" -e LITMUS_USERNAME="einstein" -e LITMUS_PASSWORD="relativity" -e TESTS="props" owncloud/litmus:latest
-> running `props':
 0. init.................. pass
 1. begin................. pass
 2. propfind_invalid...... pass
 3. propfind_invalid2..... pass
 4. propfind_d0........... pass
 5. propinit.............. pass
 6. propset............... pass
 7. propget............... pass
 8. propextended.......... pass
 9. propmove.............. pass
10. propget............... pass
11. propdeletes........... pass
12. propget............... pass
13. propreplace........... pass
14. propget............... pass
15. propnullns............ pass
16. propget............... pass
17. propremoveset......... pass
18. propget............... pass
19. propsetremove......... pass
20. propget............... pass
21. propvalnspace......... pass
22. propwformed........... FAIL (PROPFIND on `/remote.php/webdav/litmus/prop2': 207 Multi-Status)
23. propinit.............. pass
24. propmanyns............ pass
25. propget............... pass
26. propcleanup........... pass
27. finish................ pass
<- summary for `props': of 28 tests run: 27 passed, 1 failed. 96.4%
See debug.log for network/debug traces.

[PVince81]

I suspect that the remaining issue might be because we don't copy properties when a Webdav COPY is done. This is another construction site to look at.

Let's get this merged first

[PVince81]

@butonic FYI

[PVince81]

the last litmus issue is unrelated to propstat, raised here to fix separately: owncloud/ocis-reva#203

[labkode]

@PVince81 please rebase and happy to merge

[PVince81]

I should have listened to the little voice in my head who was telling me to do both PROPPATCH PRs as one 😉

And now all the "props" litmus suites are passing 🎉

% docker run -e LITMUS_URL="http://172.17.0.1:9140/remote.php/webdav" -e LITMUS_USERNAME="einstein" -e LITMUS_PASSWORD="relativity" -e TESTS="props" owncloud/litmus:latest
-> running `props':
 0. init.................. pass
 1. begin................. pass
 2. propfind_invalid...... pass
 3. propfind_invalid2..... pass
 4. propfind_d0........... pass
 5. propinit.............. pass
 6. propset............... pass
 7. propget............... pass
 8. propextended.......... pass
 9. propmove.............. pass
10. propget............... pass
11. propdeletes........... pass
12. propget............... pass
13. propreplace........... pass
14. propget............... pass
15. propnullns............ pass
16. propget............... pass
17. propremoveset......... pass
18. propget............... pass
19. propsetremove......... pass
20. propget............... pass
21. propvalnspace......... pass
22. propwformed........... pass
23. propinit.............. pass
24. propmanyns............ pass
25. propget............... pass
26. propcleanup........... pass
27. finish................ pass
<- summary for `props': of 28 tests run: 28 passed, 0 failed. 100.0%

Rebased.

[labkode]

Very nice job @PVince81