Added support for differing metrics path for Prometheus to Mentix #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge current upstream Reva
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -26,3 +26,7 @@ const ( | |||
| ExporterIDWebAPI = "webapi" | |||
| ExporterIDPrometheusFileSD = "prom_filesd" | |||
| ) | |||
|
|
|||
| const ( | |||
| PropertyMetricsPath = "metrics_path" | |||
There was a problem hiding this comment.
exported const PropertyMetricsPath should have comment (or a comment on this block) or be unexported
| @@ -26,3 +26,7 @@ const ( | |||
| ExporterIDWebAPI = "webapi" | |||
| ExporterIDPrometheusFileSD = "prom_filesd" | |||
| ) | |||
|
|
|||
| const ( | |||
| PropertyMetricsPath = "metrics_path" | |||
There was a problem hiding this comment.
exported const PropertyMetricsPath should have comment (or a comment on this block) or be unexported
| @@ -26,3 +26,7 @@ const ( | |||
| ExporterIDWebAPI = "webapi" | |||
| ExporterIDPrometheusFileSD = "prom_filesd" | |||
| ) | |||
|
|
|||
| const ( | |||
| PropertyMetricsPath = "metrics_path" | |||
There was a problem hiding this comment.
exported const PropertyMetricsPath should have comment (or a comment on this block) or be unexported
|
@Daniel-WWU-IT some hound lint comments above. |
|
It's just one actually, but it made it 3 times :D It's really just a super-unimportant comment missing, so I ignored that. This certainly isn't the only exported var/const/func that has no comment... |
labkode
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for differing metrics path when exporting scrape targets to Prometheus via Mentix. In GOCDB, a property called METRICS_PATH can now be added to override the default /metrics endpoint. This allows us to pull metrics from targets like /api/metrics etc.