Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public link file share #895

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Fix public link file share #895

merged 1 commit into from
Jun 29, 2020

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Jun 26, 2020

Provide virtual container on Webdav layer for the public link share
for a single file

  • propfind on container

  • propfind on file

  • options/head on container

  • options/head/get on file directly

  • return metadata like file size, etag, mime type

  • put on file directly replaces contents

  • check with API tests locally

  • manual test in Phoenix

    • missing properties: fileid, id, mimetype
    • file entry should not have oc:size but only getcontentlength => unrelated, separate issue as it happens on regular dav

@butonic FYI

@PVince81 PVince81 requested a review from labkode as a code owner June 26, 2020 14:03
@PVince81 PVince81 marked this pull request as draft June 26, 2020 14:04
@PVince81 PVince81 marked this pull request as ready for review June 26, 2020 15:47
@PVince81
Copy link
Contributor Author

hmm Phoenix is not displaying anything in the folder despite the correct response.

@PVince81
Copy link
Contributor Author

would be good to know if the general approach is fine

I'll fix the bugs next week

@PVince81
Copy link
Contributor Author

ok, I've added the file id and now it works in Phoenix as well.

@refs @butonic please review

@hound hound bot deleted a comment from PVince81 Jun 26, 2020
@PVince81
Copy link
Contributor Author

@refs adjusted, thanks for your hints

Provide virtual container on Webdav layer for the public link share
for a single file

It is also possible to upload/overwrite the file.

Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with @refs and @PVince81 in screenshare

@butonic butonic merged commit e33d652 into cs3org:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants