Implement GET request for single shares #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 1, 2020 14:13
Implement GET request for single shares, which tries the public share provider first and then the user share provider, similar to how isPublicShare is working. Replaced "token" with "shareID" in update code as it was meant to be the share id, to avoid confusion.
MailSend field is actually an int.
labkode
approved these changes
Jul 1, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement GET request for single shares.
Replace "token" with "shareID" in update code as it was meant to be the
share id, to avoid confusion.
Quickly tested with curl:
API tests cannot be enabled yet due to other unrelated issues further down I need to look into.