Fix OCS public link share update values logic #930
Conversation
|
and yes, OCS is not REST... one does not pass the whole object to a PUT request... |
Only update a value if it was actually set in the form. Added support for clearing expiration date and password by distinguishing between an empty string and whether the value is actually set in the request. Refactored public permission parsing to use permissionFromRequest for both creation and update of public shares.
|
/drone/src/tmp/testrunner/tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature:566 and others I'll have a look |
Make it 15 chars instead of 12 to comply with the old implementation.
|
seems the refactoring of permission logic broke the permission conversion from OC to CS3. |
|
problem solved. it was a nasty colon again... I've also added two extra fixes for expiration date and token length as they were failing in tests I'm trying to enable... |
|
hmm some other failures in the same file: /drone/src/tmp/testrunner/tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature:603 |
Adjust the public link permission mappings to make sure that we get the same "permission" values out that were put in through the API.
|
right, the old code ignored the error and I made it more strict... I've adjusted the roles just a bit to make the tests pass. I added some comments as there will be more to adjust/align later in the roles and perms (see https://github.com/owncloud/ocis-reva/issues/292) |
|
All green now! More tests will be enabled later in owncloud/core#37633 |
Only reset the password when it was explicitly set to an empty string. This fix copies the old data structure and keeps the password in place if no explicit update was requested.
|
I've added yet another fix: setting any attribute for a public link share would clear its password. This was making tests/acceptance/features/apiSharePublicLink2/updatePublicLinkShare.feature:71 in owncloud/core#37633 fail |
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go
Show resolved
Hide resolved
|
@labkode solved now, thanks |
Only update a value if it was actually set in the form.
Added support for clearing expiration date and password by
distinguishing between an empty string and whether the value is actually
set in the request.
Refactored public permission parsing to use permissionFromRequest for
both creation and update of public shares.
For owncloud/ocis-reva#252
Makes almost all tests from tests/acceptance/features/apiSharePublicLink2/multilinkSharing.feature pass now.
run more API tests to confirm that there are no regressions=> CI will help with that!