Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsers : do not walk sub trees of removed nodes and make mutations during AST walks safe #1203

Merged
merged 8 commits into from
Dec 15, 2023

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Dec 7, 2023

fixes : #1202
fixes : #1204

@romainmenke romainmenke changed the title parsers : do not walk sub trees of removed nodes parsers : do not walk sub trees of removed nodes and make mutations during AST walks safe Dec 8, 2023
@romainmenke romainmenke marked this pull request as ready for review December 8, 2023 19:00
Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

great stuff!

@romainmenke romainmenke merged commit dc68aaa into main Dec 15, 2023
7 checks passed
@romainmenke romainmenke deleted the fix-walker--adaptable-red-handed-tamarin-ca72448107 branch December 15, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make AST mutations during a walk safer Bug: replaceComponentValues() continues iterating replaced values
2 participants