Deprecate CrfNormalSegmentation

It is not implemented and does not do anything useful. Users should be warned so they do not attempt to use it.
ctbinzi · Sep 2, 2023 · 1b5f84e · 1b5f84e
1 parent 969d5d3
commit 1b5f84e
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 50 deletions.
diff --git a/segmentation/CMakeLists.txt b/segmentation/CMakeLists.txt
@@ -25,7 +25,6 @@ set(srcs
   src/organized_multi_plane_segmentation.cpp
   src/planar_polygon_fusion.cpp
   src/crf_segmentation.cpp
-  src/crf_normal_segmentation.cpp
   src/unary_classifier.cpp
   src/conditional_euclidean_clustering.cpp
   src/supervoxel_clustering.cpp

diff --git a/segmentation/include/pcl/segmentation/crf_normal_segmentation.h b/segmentation/include/pcl/segmentation/crf_normal_segmentation.h
@@ -47,7 +47,7 @@ namespace pcl
    * \author Christian Potthast
    */
   template <typename PointT>
-  class PCL_EXPORTS CrfNormalSegmentation
+  class PCL_DEPRECATED(1, 17, "CrfNormalSegmentation is not implemented and does not do anything useful") CrfNormalSegmentation
   {
     public:
       /** \brief Constructor that sets default values for member variables. */
@@ -71,6 +71,4 @@ namespace pcl
   };
 }
 
-#ifdef PCL_NO_PRECOMPILE
 #include <pcl/segmentation/impl/crf_normal_segmentation.hpp>
-#endif
diff --git a/segmentation/src/crf_normal_segmentation.cpp b/segmentation/src/crf_normal_segmentation.cpp