This repository has been archived by the owner on Jun 3, 2019. It is now read-only.
dev server host always 0.0.0.0, not host config #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am so nervous on these types of changes because of the back and forth we have had with host specification breaking some cases. @birkir I feel like you are better informed in this case. Would you mind reviewing this? |
birkir
approved these changes
May 3, 2017
There was a problem hiding this comment.
Looks good. Maybe in the future we can add a special env var for dev server port like we do at ueno: https://github.com/ueno-llc/starter-kit-universally/blob/master/internal/development/hotClientServer.js#L35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an change additional to #398 to help with remote development.
Now for example if I'm running my dev server and exposing it on a random IP,
12.23.34.45, I can setHOSTto12.23.34.45and assets will be referenced correctly, and the dev server will still attempt to start up binding to the correct 0.0.0.0