Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows qttestdriver #305

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Windows qttestdriver #305

merged 7 commits into from
Sep 27, 2024

Conversation

ursfassler
Copy link
Contributor

@ursfassler ursfassler commented Aug 1, 2024

Summary

This is the code part of PR #293. As suggested there, the Windows test for CI will be handled separately.

Details

Fixes #292.

Motivation and Context

See #293.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

@ursfassler ursfassler force-pushed the windows-qttestdriver branch 2 times, most recently from 7c0526f to a4facb1 Compare August 1, 2024 14:33
@ursfassler
Copy link
Contributor Author

@kreuzberger I took the production code changes from your PR #293 and did a small cleanup. The goal is to have this changes merged; we will see what we do about the windows tests later.

I would appreciate it if you test this changes on windows. If everything is ok, I'll squash and merge this PR.

@kreuzberger
Copy link
Contributor

@kreuzberger I took the production code changes from your PR #293 and did a small cleanup. The goal is to have this changes merged; we will see what we do about the windows tests later.

I would appreciate it if you test this changes on windows. If everything is ok, I'll squash and merge this PR.

I have build and run the tests for config release for this branch.
TLDR: The tests were successfull (exluded boost tests)

The first test run didnt work cause the test environment is NOT properly set for the QtTests (see the other changes in my PRS).
AFTER adding Qt binary dir to PATH environment variable the tests were successfull.

@ursfassler ursfassler marked this pull request as ready for review September 27, 2024 12:11
@ursfassler ursfassler merged commit fb1c702 into cucumber:main Sep 27, 2024
9 checks passed
@ursfassler ursfassler deleted the windows-qttestdriver branch September 27, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QTestDriver Implementation not working on Windows
2 participants