mk-nghttp2.bat: fix missing exports issue in libcurl.dll #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where only nghttp2-related symbols get exported when nghttp2 lib is linked to it. Build nghttp2 libs with `-DNGHTTP2_STATICLIB` so the functions are declared _without_ `__declspec(dllexport)` like the rest of functions from libcurl and libssh2.
vszakats
added a commit
that referenced
this pull request
Dec 28, 2015
mk-nghttp2.bat: fix missing exports issue in libcurl.dll
vszakats
added a commit
that referenced
this pull request
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where only nghttp2-related symbols get exported when
nghttp2 lib is linked to it. Build nghttp2 libs with
-DNGHTTP2_STATICLIBso the functions are declared without
__declspec(dllexport)like the rest of functions from libcurl and libssh2.