Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary checkout steps #70

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Conversation

cmeister2
Copy link
Collaborator

No description provided.

@cmeister2
Copy link
Collaborator Author

cmeister2 commented Dec 2, 2022

Running the job reveals:

Running: docker run --rm --privileged --shm-size=2g --platform linux/amd64 -e 
FUZZING_ENGINE=libfuzzer -e CIFUZZ=True -e SANITIZER=address -e ARCHITECTURE=x86_64 
-e FUZZING_LANGUAGE=c++ -e OUT=/github/workspace/build-out --volumes-from 69676f1feb8b 
gcr.io/oss-fuzz/curl /bin/bash -c 'cp -r /src/curl_fuzzer /github/workspace/storage/curl_fuzzer'.

and

Running: docker run --rm --privileged --shm-size=2g --platform linux/amd64 -e 
FUZZING_ENGINE=libfuzzer -e CIFUZZ=True -e SANITIZER=address -e ARCHITECTURE=x86_64 
-e FUZZING_LANGUAGE=c++ -e OUT=/github/workspace/build-out --volumes-from 69676f1feb8b 
gcr.io/oss-fuzz/curl /bin/bash -c 'cd / && rm -rf /src/curl_fuzzer/* && cp -r /github/workspace/storage/curl_fuzzer /src && cd - && compile'.

Not entirely sure where the project-src-path is coming into play yet...

@cmeister2 cmeister2 marked this pull request as ready for review December 2, 2022 16:11
@cmeister2
Copy link
Collaborator Author

It seems as if the project-src-path is unnecessary because of the magic CIFuzz code which maps in the current repository correctly for both curl and curl-fuzzer (very impressive). This PR now removes the unnecessary checkouts

@cmeister2 cmeister2 changed the title Investigating the project-src-path mode of cifuzz Remove unnecessary checkout steps Dec 2, 2022
@cmeister2 cmeister2 merged commit 6adbacb into master Dec 5, 2022
@cmeister2 cmeister2 deleted the cm2/moreinvestigation branch December 5, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant