-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVAT-3D milestone6 #3234
CVAT-3D milestone6 #3234
Conversation
Hi @nmanovic , So in-order to check if only known 2D cases are failing and 3D test cases have passed, can we pull the latest cvat-3D-Milestone6 branch changes in the above mentioned PRs, can someone help us with that? |
@manasars , I believe you always can merge both PRs into your branch. I don't think you need help from our side. |
… cvat-3D-Milestone6
…t-3d-m6' into cvat-3D-Milestone6
Hi @zhiltsov-max, So will this be changed in Datumaro or should we update the unit tests accordingly? |
Probably, you don't need to pass Updates related to the develop branch of Datumaro are in #3411 |
@manasars , do we have any other questions? Really need to complete the PR this week and merge. |
Hi @nmanovic, We have fixed the cypress tests and all the tests have passed. |
attributes["track_id"] = -1 | ||
index += 1 | ||
|
||
dm_item = datumaro.DatasetItem(id=osp.split(frame_data.name)[-1].split('.')[0], image=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dm_item = datumaro.DatasetItem(id=osp.split(frame_data.name)[-1].split('.')[0], image=None, | |
dm_item = datumaro.DatasetItem(id=osp.splitext(frame_data.name)[0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zhiltsov-max , the osp.splitext(frame_data.name)[0] returns the entire file path and not just the fileName.
We can leave it as above or change to :
id=osp.splitext(osp.split(frame_data.name)[-1])[0]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to return only basename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @zhiltsov-max,
As per the suggest changes we are getting the folder structure as shown below, "test_canvas3d/pointcloud/" is nested inside ann, pointcloud and related images folders before the actual data.
Hence we only require the basename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CVAT preserves relative image paths on export, so such behavoiur is probably expected for PCD too. But it can be a problem of the specific test, if "test_canvas3d/pointcloud/" is not supposed to be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhiltsov-max, If we make the suggested change id=osp.splitext(frame_data.name)[0] then the folder structure downloaded on click of dump annotations manually is as above which is incorrect as per SOW and not compatible with supervisely.
Hi @zhiltsov-max : I hope we are fine with all the review changes, kindly confirm. |
@manasars , did I miss something? I cannot rotate, zoom in/out, move the primary view using mouse. Is it expected? |
@manasars , could you please point me on the review comment? |
@manasars , I see a problem with projections of points. If you look at the screenshot below, you will see that side and front views are not informative at all. At the same time in the alternative annotation tools, it is easy to see boundaries of these objects on side and front views. |
Please find points 3 and 6 in the below link |
Do you mean the comment below? If it isn't a request from our team, I'm not OK with such fix. In CVAT 2D and other annotation tools it is possible to interact with a frame using mouse by default. In the reference tool the mode is also activated by default. I like the ability to press buttons, but in reality it is much faster to interact with a scene using mouse. Do you agree? |
@manasars , let me merge the PR, but I will wrote a separate mail with known problems which should be resolved. |
@manasars , I summarized found issues here: #3438 It isn't all issues, but which I found during the final review today. I hope the list will not grow. Please review and comment. |
Hi @bsekachev , @nmanovic , @zhiltsov-max
CVAT 3D Milestone 6 changes:
Added support for Dump annotations, Export Annotations and Upload annotations in PCD and Kitti formats.
The code changes are only in 4 files i.e bindings.py, registry.py and added new datatsets pointcloud.py and velodynepoint.py.
The rest of the files are from M5 base branch, was waiting for it to be merged but since comments are in progress created one for M6.
If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
I submit my changes into the
develop
branchWe shall add the changes in CHANGELOG after M5 code is merged .
(https://github.com/opencv/cvat/blob/develop/CHANGELOG.md) file
Datumaro PR - CVAT-3D Milestone-6 PCD and Kitti formats openvinotoolkit/datumaro#245
I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
I have updated the license header for each file