Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launch.json #3625

Merged
merged 4 commits into from
Sep 6, 2021
Merged

Update launch.json #3625

merged 4 commits into from
Sep 6, 2021

Conversation

dhivyasreedhar
Copy link
Contributor

@dhivyasreedhar dhivyasreedhar commented Aug 30, 2021

Changed .vscode\launch.json for compatibility issues.

Copyright (C) 2020-2021 Intel Corporation

SPDX-License-Identifier: MIT

Motivation and context

Fixed [#3525]
Chrome debugger for vs-code is deprecated now, so we should move to the JavaScript Debugger

How has this been tested?

All tests were passed while testing in JavaScript Workflow

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)

Changed .vscode\launch.json for compatibility with JavaScript Debugger
@ActiveChooN
Copy link
Contributor

@dhivyasreedhar, hi, thank you for your contribution. There is should be some browser debugger task, not a pure node process one. So I guess the correct type of script is pwa-chrome.

@dhivyasreedhar
Copy link
Contributor Author

@dhivyasreedhar, hi, thank you for your contribution. There is should be some browser debugger task, not a pure node process one. So I guess the correct type of script is pwa-chrome.

@ActiveChooN So the type in the launch.json should be changed to 'pwa-chrome' ?

@ActiveChooN
Copy link
Contributor

@dhivyasreedhar, hi, thank you for your contribution. There is should be some browser debugger task, not a pure node process one. So I guess the correct type of script is pwa-chrome.

@ActiveChooN So the type in the launch.json should be changed to 'pwa-chrome' ?

Yes, it should.

@dhivyasreedhar
Copy link
Contributor Author

@dhivyasreedhar, hi, thank you for your contribution. There is should be some browser debugger task, not a pure node process one. So I guess the correct type of script is pwa-chrome.

@ActiveChooN So the type in the launch.json should be changed to 'pwa-chrome' ?

Yes, it should.

@ActiveChooN I have made the necessary changes. Check it out.

.vscode/launch.json Outdated Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
dhivyasreedhar and others added 2 commits September 6, 2021 14:05
Co-authored-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Co-authored-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Copy link
Contributor Author

@dhivyasreedhar dhivyasreedhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes reviewed.

@nmanovic nmanovic merged commit d80d241 into cvat-ai:develop Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome debugger for vs-code is deprecated
3 participants