CVAT authentication #5147

Marishka17 · 2022-10-20T09:15:18Z

Motivation and context

PR contains changes to support social authentication with google and github providers. Also several bugs with related field were fixed. Resolved issue #4820. There is now possible to request another mail with email confirmation link.
Resolved issue #4832 with attempt to confirm email one more time with the same confirmation link.
I guess this issue #4837 can also be closed because now we can send another confirmation email.

How has this been tested?

Manually

Checklist

I submit my changes into the develop branch
I have added a description of my changes into CHANGELOG file
I have updated the documentation accordingly
I have added tests to cover my changes
I have linked related issues (read github docs)
I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

cvat/apps/iam/templates/account/email/email_confirmation_signup_message.html

cvat/apps/iam/templates/account/email/email_confirmation_message.html

Marishka17 · 2022-10-25T22:52:32Z

/check

github-actions · 2022-10-25T22:52:44Z

❌ Some checks failed
📄 See logs here

Marishka17 · 2022-10-26T15:02:47Z

/check

github-actions · 2022-10-26T15:03:01Z

✔️ All checks completed successfully
📄 See logs here

cvat/apps/iam/views.py

azhavoro · 2022-10-27T06:32:22Z

cvat/apps/iam/templates/account/email/email_confirmation_message.html

+  <meta http-equiv="x-ua-compatible" content="ie=edge">
+  <title>Email Confirmation</title>
+  <meta name="viewport" content="width=device-width, initial-scale=1">
+  <style type="text/css">


please make sure the template is correctly rendered in the popular email clients like gmail, apple mail, etc

azhavoro · 2022-10-27T06:32:28Z

cvat/apps/engine/views.py

+        }
+    )
+    @action(detail=False, methods=['GET'], url_path='advanced-auth', permission_classes=[])
+    def advanced_authentication(request):


Shouldn't this endpoint be a part of IAM app?

I guess no, because it's part of server configuration

@Marishka17 , I agree that the question is very ambiguous. But I also think that it is more IAM configuration than the server. I will prefer to have something like /api/auth/methods or something similar.

cvat/apps/iam/views.py

azhavoro · 2022-10-27T06:36:08Z

cvat/settings/base.py

@@ -571,3 +575,47 @@ def add_ssh_keys():
    'SCHEMA_PATH_PREFIX': '/api',
    'SCHEMA_PATH_PREFIX_TRIM': False,
 }
+
+# allauth configuration
+USE_ALLAUTH_SOCIAL_ACCOUNTS = strtobool(os.getenv('USE_ALLAUTH_SOCIAL_ACCOUNTS') or 'False')


or 'False' is really need here?

if an env variable is set to empty string then strtobool will not be able to convert it to bool

docker-compose.yml

…&& fix login when email is private

nmanovic · 2022-10-29T08:29:53Z

/check

github-actions · 2022-10-29T08:30:08Z

✔️ All checks completed successfully
📄 See logs here

Marishka17 · 2022-11-03T10:52:44Z

/check

github-actions · 2022-11-03T10:52:57Z

✔️ All checks completed successfully
📄 See logs here

nmanovic · 2022-11-05T05:44:48Z

cvat/settings/base.py

@@ -574,3 +579,52 @@ def add_ssh_keys():
    'SCHEMA_PATH_PREFIX': '/api',
    'SCHEMA_PATH_PREFIX_TRIM': False,
 }
+
+# allauth configuration
+USE_ALLAUTH_SOCIAL_ACCOUNTS = strtobool(os.getenv('USE_ALLAUTH_SOCIAL_ACCOUNTS') or 'False')


Suggested change

USE_ALLAUTH_SOCIAL_ACCOUNTS = strtobool(os.getenv('USE_ALLAUTH_SOCIAL_ACCOUNTS') or 'False')

USE_ALLAUTH_SOCIAL_ACCOUNTS = strtobool(os.getenv('USE_ALLAUTH_SOCIAL_ACCOUNTS', 'False'))

nmanovic · 2022-11-05T05:49:46Z

cvat/settings/base.py

+    SOCIALACCOUNT_QUERY_EMAIL = True
+    SOCIALACCOUNT_CALLBACK_CANCELLED_URL = '/auth/login'
+
+    GITHUB_CALLBACK_URL = 'http://localhost:8080/api/auth/github/login/callback/'


@Marishka17 , Can we avoid specifying here http://localhost:8080 and calculate it automatically in runtime?

nmanovic · 2022-11-05T06:05:05Z

cvat-ui/src/reducers/index.ts

@@ -14,6 +14,15 @@ export type StringObject = {
    [index: string]: string;
 };

+enum AdvancedAuthMethods {
+    GOOGLE_ACCOUNT_AUTHENTICATION = 'GOOGLE_ACCOUNT_AUTHENTICATION',


@Marishka17 , @bsekachev , do you think we can avoid duplication? We get the same information from the server. I will prefer to have a REST API method to get all the necessary information from the server to render UI. Now we have a list of available methods on the server and UI at the same time.

nmanovic · 2022-11-05T06:17:04Z

@Marishka17 , let's merge as is. But I expect that you fix the comments in your next PRs.

Add social accounts authentication && improve email confirmation

6d62901

Marishka17 requested review from bsekachev and nmanovic as code owners October 20, 2022 09:15

github-advanced-security bot found potential problems Oct 20, 2022

View reviewed changes

cvat/apps/iam/templates/account/email/email_confirmation_signup_message.html Fixed Show fixed Hide fixed

cvat/apps/iam/templates/account/email/email_confirmation_message.html Fixed Show fixed Hide fixed

Marishka17 added 4 commits October 20, 2022 14:22

Pass env variables to docker

73258dc

Update helm chart

f81564b

Update email verification templates

a15725f

Small refactoring

60e0535

Marishka17 requested a review from azhavoro as a code owner October 20, 2022 23:26

Marishka17 added 6 commits October 21, 2022 16:45

Send email verification && redirect to /auth/email-verification-sent

b9808f2

Fix helm chart

fa6d06a

Fix typo

606ee5a

Pass enabled advanced auth methods to client

fa5e5db

Merge branch 'develop' into mk/authentication

643dc48

Rename class

83ffc62

Marishka17 assigned azhavoro Oct 25, 2022

Fix

3f4b7c7

Marishka17 force-pushed the mk/authentication branch from cb62be7 to 707edac Compare October 26, 2022 08:46

Marishka17 added 2 commits October 26, 2022 11:07

Fix helm

6ca9a2e

Fix github scope

b52285f

Marishka17 force-pushed the mk/authentication branch from 707edac to b52285f Compare October 26, 2022 09:08

Marishka17 added 3 commits October 26, 2022 15:27

Some fixes

bcd93c5

Fix schema generation

36e42bd

Fixes

e6859e2

cvat-ai deleted a comment from github-actions bot Oct 26, 2022

azhavoro reviewed Oct 27, 2022

View reviewed changes

Marishka17 added 2 commits October 27, 2022 11:26

Apply comments

25a6ddc

Update changelog

e8c4dd6

klakhov mentioned this pull request Oct 28, 2022

New authentication UI #5181

Merged

7 tasks

Marishka17 added 4 commits October 28, 2022 12:43

Add more user friendly page when email confirmation url is incorrect …

936a25f

…&& fix login when email is private

Fix pylint

d1cdb7e

Redirect to login page after cansel authorization

63bfbb1

Fix bandit

a2f010f

Marishka17 changed the title ~~[WIP] CVAT authentication~~ CVAT authentication Oct 28, 2022

Merge branch 'develop' into mk/authentication

da92b3f

Marishka17 added 2 commits November 4, 2022 10:52

Update enabled advanced authentication methods

c71ea8f

Update dev callback urls

d0f27cc

nmanovic reviewed Nov 5, 2022

View reviewed changes

nmanovic approved these changes Nov 5, 2022

View reviewed changes

nmanovic merged commit bb48716 into develop Nov 5, 2022

nmanovic deleted the mk/authentication branch November 5, 2022 06:18

This was referenced Nov 30, 2022

Second click on a confirmation link for registration lead to 500 error #4841

Closed

Ability to send new verification email #4820

Closed

Server error 500 occurs open invaid (account is already active, invalid token, etc.) account activation link #4832

Closed

nmanovic mentioned this pull request Dec 12, 2022

CVAT v2.3.0 #5452

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CVAT authentication #5147

CVAT authentication #5147

Marishka17 commented Oct 20, 2022 •

edited

Loading

Marishka17 commented Oct 25, 2022

github-actions bot commented Oct 25, 2022 •

edited

Loading

Marishka17 commented Oct 26, 2022

github-actions bot commented Oct 26, 2022 •

edited

Loading

azhavoro Oct 27, 2022

azhavoro Oct 27, 2022

Marishka17 Oct 27, 2022

nmanovic Nov 5, 2022

azhavoro Oct 27, 2022

Marishka17 Oct 27, 2022

nmanovic commented Oct 29, 2022

github-actions bot commented Oct 29, 2022 •

edited

Loading

Marishka17 commented Nov 3, 2022

github-actions bot commented Nov 3, 2022 •

edited

Loading

nmanovic Nov 5, 2022

nmanovic Nov 5, 2022

nmanovic Nov 5, 2022

nmanovic commented Nov 5, 2022

	USE_ALLAUTH_SOCIAL_ACCOUNTS = strtobool(os.getenv('USE_ALLAUTH_SOCIAL_ACCOUNTS') or 'False')
	USE_ALLAUTH_SOCIAL_ACCOUNTS = strtobool(os.getenv('USE_ALLAUTH_SOCIAL_ACCOUNTS', 'False'))

CVAT authentication #5147

CVAT authentication #5147

Conversation

Marishka17 commented Oct 20, 2022 • edited Loading

Motivation and context

How has this been tested?

Checklist

License

Marishka17 commented Oct 25, 2022

github-actions bot commented Oct 25, 2022 • edited Loading

Marishka17 commented Oct 26, 2022

github-actions bot commented Oct 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nmanovic commented Oct 29, 2022

github-actions bot commented Oct 29, 2022 • edited Loading

Marishka17 commented Nov 3, 2022

github-actions bot commented Nov 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nmanovic commented Nov 5, 2022

Marishka17 commented Oct 20, 2022 •

edited

Loading

github-actions bot commented Oct 25, 2022 •

edited

Loading

github-actions bot commented Oct 26, 2022 •

edited

Loading

github-actions bot commented Oct 29, 2022 •

edited

Loading

github-actions bot commented Nov 3, 2022 •

edited

Loading