Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock 'Ok' button when there is no selected file to upload #5757

Merged
merged 6 commits into from
Feb 23, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Feb 23, 2023

Motivation and context

Resolved #5633
Also fixed storage selection when uploading a dataset

image

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev added the bug Something isn't working label Feb 23, 2023
@bsekachev bsekachev requested review from Marishka17 and removed request for nmanovic February 23, 2023 08:00
@bsekachev bsekachev changed the title [WIP] Lock 'Ok' button when there is no selected file to upload Дock 'Ok' button when there is no selected file to upload Feb 23, 2023
@bsekachev bsekachev changed the title Дock 'Ok' button when there is no selected file to upload Lock 'Ok' button when there is no selected file to upload Feb 23, 2023
@bsekachev bsekachev changed the title Lock 'Ok' button when there is no selected file to upload [WIP] Lock 'Ok' button when there is no selected file to upload Feb 23, 2023
@bsekachev bsekachev changed the title [WIP] Lock 'Ok' button when there is no selected file to upload Lock 'Ok' button when there is no selected file to upload Feb 23, 2023
Copy link
Contributor

@Marishka17 Marishka17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it works for me

@bsekachev bsekachev merged commit 43da7ab into develop Feb 23, 2023
@bsekachev bsekachev deleted the bs/fixed_issue_5633 branch February 28, 2023 21:57
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
Resolved cvat-ai#5633
Also fixed storage selection when uploading a dataset

<img width="268" alt="image"
src="https://user-images.githubusercontent.com/40690378/220912019-b0596c2d-94f4-4b8f-a26f-18b0cfb6efa4.png">



### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [x] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent import without the file
2 participants