Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct service name in LDAP authentication documentation #5848

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

RyanHir
Copy link
Contributor

@RyanHir RyanHir commented Mar 13, 2023

Update documentation to use the proper service when enabling LDAP authentication.

Motivation and context

The current documentation references a service (cvat) that is now renamed to cvat_server. This change makes this apparent.

How has this been tested?

Used the same configs as described in the guide with a Windows Server 2022 instance, and only deviated from the instructions as to select the correct docker service. This PR has this change.

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@RyanHir RyanHir requested a review from nmanovic as a code owner March 13, 2023 18:05
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RyanHir , thanks for the contribution!

@nmanovic nmanovic merged commit d240331 into cvat-ai:develop Mar 15, 2023
@RyanHir RyanHir deleted the ldap-docs branch March 15, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants