Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed functions code && supported functions plugin #5979

Merged
merged 34 commits into from
Nov 9, 2023

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Apr 5, 2023

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov requested a review from bsekachev as a code owner April 5, 2023 16:39
cvat-core/src/api-implementation.ts Outdated Show resolved Hide resolved
cvat-core/src/lambda-manager.ts Outdated Show resolved Hide resolved
cvat-core/src/ml-model.ts Outdated Show resolved Hide resolved
cvat-ui/src/reducers/plugins-reducer.ts Outdated Show resolved Hide resolved
cvat-ui/src/reducers/plugins-reducer.ts Outdated Show resolved Hide resolved
cvat-ui/src/reducers/index.ts Outdated Show resolved Hide resolved
@klakhov klakhov marked this pull request as draft September 12, 2023 07:40
@klakhov klakhov marked this pull request as ready for review September 13, 2023 09:07
cvat-ui/src/components/models-page/deployed-model-item.tsx Outdated Show resolved Hide resolved
cvat-ui/src/reducers/plugins-reducer.ts Outdated Show resolved Hide resolved
cvat-ui/src/components/plugins-entrypoint.tsx Outdated Show resolved Hide resolved
cvat-ui/src/components/plugins-entrypoint.tsx Outdated Show resolved Hide resolved
cvat-ui/src/components/models-page/top-bar.tsx Outdated Show resolved Hide resolved
cvat-core/src/ml-model.ts Outdated Show resolved Hide resolved
cvat-core/src/api-implementation.ts Outdated Show resolved Hide resolved
@klakhov klakhov marked this pull request as draft October 30, 2023 13:15
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #5979 (7b4d5f3) into develop (1ef6ba0) will increase coverage by 0.17%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop    #5979      +/-   ##
===========================================
+ Coverage    82.39%   82.56%   +0.17%     
===========================================
  Files          362      362              
  Lines        39405    39264     -141     
  Branches      3592     3578      -14     
===========================================
- Hits         32467    32419      -48     
+ Misses        6938     6845      -93     
Components Coverage Δ
cvat-ui 77.71% <66.66%> (+0.31%) ⬆️
cvat-server 86.96% <ø> (+<0.01%) ⬆️

@klakhov klakhov marked this pull request as ready for review October 31, 2023 11:44
cvat-core/src/lambda-manager.ts Outdated Show resolved Hide resolved
cvat-core/src/ml-model.ts Outdated Show resolved Hide resolved
cvat-core/src/server-proxy.ts Outdated Show resolved Hide resolved
cvat-ui/src/components/models-page/model-provider-icon.tsx Outdated Show resolved Hide resolved
Copy link
Member

@bsekachev bsekachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but postpone merge, because I need first to look at the second part

@nmanovic nmanovic merged commit c87cb3b into develop Nov 9, 2023
34 checks passed
@nmanovic nmanovic deleted the kl/functions-plugin branch November 9, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants