Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: visible 'To background' button in review mode #6363

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jun 23, 2023

Motivation and context

Resolved #6297

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested a review from mdacoca as a code owner June 23, 2023 04:26
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #6363 (5d95d40) into develop (ec149df) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6363      +/-   ##
===========================================
- Coverage    81.83%   81.69%   -0.15%     
===========================================
  Files          321      321              
  Lines        37601    37329     -272     
  Branches      6917     6756     -161     
===========================================
- Hits         30771    30495     -276     
- Misses        6513     6526      +13     
+ Partials       317      308       -9     
Components Coverage Δ
cvat-ui 77.09% <ø> (-0.07%) ⬇️
cvat-server 85.84% <ø> (-0.16%) ⬇️

@bsekachev bsekachev requested review from klakhov and removed request for mdacoca June 23, 2023 05:44
@bsekachev bsekachev merged commit ea6c68f into develop Jun 23, 2023
12 checks passed
@bsekachev bsekachev deleted the bs/fixed_issue_6297 branch June 23, 2023 09:20
@azhavoro azhavoro mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"To background" button is visible in object menu in Review mode
2 participants