Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close av contaner after use #6501

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Close av contaner after use #6501

merged 3 commits into from
Jul 19, 2023

Conversation

azhavoro
Copy link
Contributor

@azhavoro azhavoro commented Jul 18, 2023

Motivation and context

Test: run YOLO v7 on 350 frames on video task
before:
wo_fix
after:
with_fix

full records:
https://asciinema.org/a/kIp3QqsMd3MNs5Ft4LCq97vp7
https://asciinema.org/a/qpwdvrbET6CBM8k5iNc6sU2Ff

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #6501 (9e6121a) into develop (bc5036f) will decrease coverage by 0.01%.
The diff coverage is 62.16%.

@@             Coverage Diff             @@
##           develop    #6501      +/-   ##
===========================================
- Coverage    81.71%   81.70%   -0.01%     
===========================================
  Files          337      337              
  Lines        38499    38496       -3     
  Branches      3540     3540              
===========================================
- Hits         31460    31455       -5     
- Misses        7039     7041       +2     
Components Coverage Δ
cvat-ui 75.10% <ø> (-0.02%) ⬇️
cvat-server 87.81% <62.16%> (+<0.01%) ⬆️

@azhavoro azhavoro changed the title close av contaner after use Close av contaner after use Jul 18, 2023
cvat/apps/engine/media_extractors.py Outdated Show resolved Hide resolved
cvat/apps/engine/media_extractors.py Outdated Show resolved Hide resolved
cvat/apps/engine/media_extractors.py Show resolved Hide resolved
@azhavoro azhavoro requested a review from mdacoca as a code owner July 18, 2023 15:09
@SpecLad
Copy link
Contributor

SpecLad commented Jul 18, 2023

FYI, there's a merge conflict.

@nmanovic nmanovic merged commit 783c414 into develop Jul 19, 2023
34 checks passed
@nmanovic nmanovic deleted the az/av_memory_leak branch July 19, 2023 04:06
azhavoro added a commit that referenced this pull request Jul 19, 2023
@azhavoro azhavoro mentioned this pull request Jul 19, 2023
bsekachev pushed a commit that referenced this pull request Jul 20, 2023
## \[2.5.1\] - 2023-07-19
### Fixed
- Memory leak related to unclosed av container
(<#6501>)
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants