Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved lambda manager #6734

Merged
merged 15 commits into from
Aug 24, 2023
Merged

Improved lambda manager #6734

merged 15 commits into from
Aug 24, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Aug 22, 2023 •
edited
Loading

Motivation and context

  • First status check request after 20 seconds may confuse users making them think that something going wrong
  • Fixed a reason of a big amount status check requests (repeated calls for listen() method) when user go from Tasks -> any other page -> Tasks -> any other page -> Task -> any other page -> Task, etc not closing the tab.
  • Fixed bug when the progress invisible if the app initialized on task page
  • Fixed 403 code when user tries to cancel automatic annotation
  • Added missed schema endpoint
  • Added more informative progress (for queued/in progress/fail):
image image

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested review from klakhov and removed request for mdacoca August 22, 2023 16:39
@codecov
Copy link

codecov bot commented Aug 23, 2023 •
edited
Loading

Codecov Report

Merging #6734 (e7f3de4) into develop (948db75) will decrease coverage by 0.08%.
Report is 7 commits behind head on develop.
The diff coverage is 6.25%.

@@             Coverage Diff             @@
##           develop    #6734      +/-   ##
===========================================
- Coverage    82.50%   82.43%   -0.08%     
===========================================
  Files          366      366              
  Lines        39810    39824      +14     
  Branches      3538     3543       +5     
===========================================
- Hits         32846    32828      -18     
- Misses        6964     6996      +32
Components Coverage Δ
cvat-ui 77.39% <0.00%> (-0.16%) ⬇️
cvat-server 86.83% <100.00%> (ø)

klakhov
klakhov approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch works well for me

nmanovic
nmanovic approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 4a5aa28 into develop Aug 24, 2023
33 checks passed
@nmanovic nmanovic deleted the bs/improve_lambda branch August 24, 2023 08:29
@azhavoro azhavoro mentioned this pull request Aug 25, 2023
Merged
jonybekov pushed a commit to tezzro/cvat that referenced this pull request Sep 6, 2023
@bsekachev @jonybekov
Improved lambda manager (cvat-ai#6734)
85d8f11 
* First status check request after 20 seconds may confuse users making
them think that something going wrong
* Fixed a reason of a big amount status check requests (repeated calls
for listen() method) when user go from Tasks -> any other page -> Tasks
-> any other page -> Task -> any other page -> Task, etc not closing the
tab.
* Fixed bug when the progress invisible if the app initialized on task
page
* Fixed 403 code when user tries to cancel automatic annotation
* Added missed schema endpoint
* Added more informative progress (for queued/in progress/fail):

<img width="756" alt="image"
src="https://github.com/opencv/cvat/assets/40690378/f01c45a8-a460-48c0-bec4-88266bb65a2c">
<img width="980" alt="image"
src="https://github.com/opencv/cvat/assets/40690378/f9e2c5ad-c2b7-4c43-8214-34236f38103b">
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
@bsekachev @mikhail-treskin
Improved lambda manager (cvat-ai#6734)
58afd40 
* First status check request after 20 seconds may confuse users making
them think that something going wrong
* Fixed a reason of a big amount status check requests (repeated calls
for listen() method) when user go from Tasks -> any other page -> Tasks
-> any other page -> Task -> any other page -> Task, etc not closing the
tab.
* Fixed bug when the progress invisible if the app initialized on task
page
* Fixed 403 code when user tries to cancel automatic annotation
* Added missed schema endpoint
* Added more informative progress (for queued/in progress/fail):

<img width="756" alt="image"
src="https://github.com/opencv/cvat/assets/40690378/f01c45a8-a460-48c0-bec4-88266bb65a2c">
<img width="980" alt="image"
src="https://github.com/opencv/cvat/assets/40690378/f9e2c5ad-c2b7-4c43-8214-34236f38103b">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmanovic nmanovic nmanovic approved these changes

@klakhov klakhov klakhov approved these changes

@Marishka17 Marishka17 Awaiting requested review from Marishka17 Marishka17 is a code owner

@SpecLad SpecLad Awaiting requested review from SpecLad SpecLad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsekachev @nmanovic @klakhov