Add a GitHub workflow for finalizing a release #6998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This automates the second half of the release process (the first being automated by `prepare-release.yml`). After this workflow completes, the only action that should remain for the releaser to do is to merge the `dev-release-*` pull request. We can't do that as part of this workflow, because CI has to finish first, and it seems pointless to create another workflow just to merge 1 PR. Apply some of the aspects of this pipeline to `prepare-release.yml` as well: * Make the release notes extraction process more sophisticated to work around GitHub's frustrating handling of line breaks in PR and release descriptions. * Use GitHub app credentials in order to be able to trigger other pipelines.
SpecLad
force-pushed
the
finalize-release-workflow
branch
from
eae68da
to
55f23cc
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6998 +/- ##
===========================================
- Coverage 82.60% 82.54% -0.06%
===========================================
Files 360 360
Lines 38922 38977 +55
Branches 3570 3577 +7
===========================================
+ Hits 32150 32174 +24
- Misses 6772 6803 +31
|
azhavoro
reviewed
Oct 16, 2023
azhavoro
approved these changes
Oct 18, 2023
|
I had an issue yesterday with using this workflow: https://github.com/opencv/cvat/actions/runs/6618431921/job/17976838325 |
|
Looks like it ran afoul of the branch protection rules. I've now added cvat-bot to the list of people who are allowed to push to |
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
This automates the second half of the release process (the first being automated by `prepare-release.yml`). After this workflow completes, the only action that should remain for the releaser to do is to merge the `dev-release-*` pull request. We can't do that as part of this workflow, because CI has to finish first, and it seems pointless to create another workflow just to merge 1 PR. Apply some of the aspects of this pipeline to `prepare-release.yml` as well: * Make the release notes extraction process more sophisticated to work around GitHub's frustrating handling of line breaks in PR and release descriptions. * Use GitHub app credentials in order to be able to trigger other pipelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This automates the second half of the release process (the first being automated by
prepare-release.yml). After this workflow completes, the only action that should remain for the releaser to do is to merge thedev-release-*pull request. We can't do that as part of this workflow, because CI has to finish first, and it seems pointless to create another workflow just to merge 1 PR.Apply some of the aspects of this pipeline to
prepare-release.ymlas well:Make the release notes extraction process more sophisticated to work around GitHub's frustrating handling of line breaks in PR and release descriptions.
Use GitHub app credentials in order to be able to trigger other pipelines.
How has this been tested?
I tried the pipelines on my CVAT fork.
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.