Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress changeFrame events #7048

Merged
merged 12 commits into from
Nov 2, 2023
Merged

Compress changeFrame events #7048

merged 12 commits into from
Nov 2, 2023

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Oct 24, 2023

Motivation and context

We have too many event records of changeFrame and zoomImage events. They are not really informative. This pr compresses changeFrame events and increases ignore events timeouts

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • [] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #7048 (c6cc4e7) into develop (c6682ff) will increase coverage by 0.01%.
Report is 13 commits behind head on develop.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop    #7048      +/-   ##
===========================================
+ Coverage    82.33%   82.34%   +0.01%     
===========================================
  Files          361      361              
  Lines        39213    39275      +62     
  Branches      3585     3591       +6     
===========================================
+ Hits         32286    32341      +55     
- Misses        6927     6934       +7     
Components Coverage Δ
cvat-ui 77.34% <100.00%> (-0.02%) ⬇️
cvat-server 86.93% <81.25%> (+0.03%) ⬆️

@nmanovic nmanovic merged commit d2b5f3d into develop Nov 2, 2023
34 checks passed
@nmanovic nmanovic deleted the kl/ignore-change-frame-events branch November 2, 2023 15:37
@cvat-bot cvat-bot bot mentioned this pull request Nov 3, 2023
bsekachev pushed a commit that referenced this pull request Nov 6, 2023
We have too many event records of `changeFrame` and `zoomImage` events.
They are not really informative. This pr compresses `changeFrame` events
and increases ignore events timeouts
 
Co-authored-by: Andrey Zhavoronkov <andrey@cvat.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants