Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC2024] Displayed total no. of annotations #7654

Merged
merged 16 commits into from
Apr 4, 2024

Conversation

KrishavRajSingh
Copy link
Contributor

Motivation and context

Fixes #4662
If a person wants to see quickly total no. of annotations, this section may come useful.

How has this been tested?

image

Checklist

  • [ *] I submit my changes into the develop branch
  • [ *] I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • [ *] I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • [ *] I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@nmanovic nmanovic changed the title [GSoc24] Displayed total no. of annotations [GSoC2024] Displayed total no. of annotations Mar 21, 2024
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature seems to be working, could you add a simple cypress test for it?

KrishavRajSingh and others added 3 commits March 23, 2024 20:24
Co-authored-by: Kirill Lakhov <kirill.9992@gmail.com>
Co-authored-by: Kirill Lakhov <kirill.9992@gmail.com>
Co-authored-by: Kirill Lakhov <kirill.9992@gmail.com>
@KrishavRajSingh
Copy link
Contributor Author

The feature seems to be working, could you add a simple cypress test for it?

Hey, it will be good if you refer me some documentation for testing in cvat as I am pretty new to testing.

@klakhov
Copy link
Contributor

klakhov commented Mar 26, 2024

Hi, you can find e2e tests documentation here. You can find lots of cypress test examples here.
Basically we need to create several objects in the job and test if the sidebar shows correct number.

@klakhov klakhov added the ui/ux label Mar 26, 2024
@bsekachev
Copy link
Member

  1. Are ground truth objects considered in the counter?
  2. What do you think regarding adding the same feature for labels and issues?
  3. Will it be possible to add them to Tab headers?
  4. I am not sure "No. of annotations: " is a good option, because abbreviation for "No" is not so obvious

@KrishavRajSingh
Copy link
Contributor Author

  1. Are ground truth objects considered in the counter?
  2. What do you think regarding adding the same feature for labels and issues?
  3. Will it be possible to add them to Tab headers?
  4. I am not sure "No. of annotations: " is a good option, because abbreviation for "No" is not so obvious
  1. Yes, they are considered. What I have done is displayed the length of objectStates. Here is an example:
    Count_annotation.webm
  2. I think it is a good idea and am ready to add if you say.
  3. Do you mean to replace this here ->
    tabHeader
    ??
  4. What is your opinion on "Total annotations"??

@bsekachev
Copy link
Member

I think it is a good idea and am ready to add if you say.

Yes, it would be great.

What is your opinion on "Total annotations"??

Just "Total count"?

Do you mean to replace this here ->

I thought one more time, let's left as is.

@KrishavRajSingh
Copy link
Contributor Author

KrishavRajSingh commented Apr 1, 2024

In this commit I have added "Total Count" for issues and labels.
video

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #7654 (81c66e1) into develop (02889ee) will increase coverage by 0.01%.
Report is 6 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7654      +/-   ##
===========================================
+ Coverage    83.36%   83.37%   +0.01%     
===========================================
  Files          373      373              
  Lines        39722    39722              
  Branches      3747     3747              
===========================================
+ Hits         33113    33118       +5     
+ Misses        6609     6604       -5     
Components Coverage Δ
cvat-ui 79.23% <ø> (+0.03%) ⬆️
cvat-server 87.21% <ø> (-0.01%) ⬇️

@KrishavRajSingh
Copy link
Contributor Author

Hi, you can find e2e tests documentation here. You can find lots of cypress test examples here. Basically we need to create several objects in the job and test if the sidebar shows correct number.

Hey, I was trying to write some tests but I am not able to login to localhost:8080 in my browser. Localhost:3000 works fine. Where am I doing it wrong??

@bsekachev
Copy link
Member

localhost:8080 is default when deploy in docker, localhost:3000 is default in dev environment.
You may modify tests/cypress.config.json to update application URL

@bsekachev
Copy link
Member

I will merge this pull request, please send tests as a separate one.
Thank you.

@bsekachev bsekachev merged commit 69682f2 into cvat-ai:develop Apr 4, 2024
32 checks passed
@cvat-bot cvat-bot bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of annotation on a single image
3 participants