[GSoC2024] Enhancement of empty list components #7659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@syedbarimanjan , Is it ready? Can we look at the PR? If so, please remove draft label. |
|
@klakhov could you take a look. |
syedbarimanjan
commented
Mar 24, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7659 +/- ##
========================================
Coverage 83.44% 83.44%
========================================
Files 373 373
Lines 39726 39716 -10
Branches 3741 3741
========================================
- Hits 33149 33142 -7
+ Misses 6577 6574 -3
|
klakhov
requested review from
klakhov
and removed request for
bsekachev and
azhavoro
klakhov
reviewed
Mar 26, 2024
cvat-ui/src/components/cloud-storages-page/cloud-storages-page.tsx
Outdated
Show resolved
Hide resolved
|
Hi @syedbarimanjan , |
Yes I will push the changes today my pc got damaged thats why it took long. |
klakhov
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Hi @syedbarimanjan,
I've added a couple more comments, please check them.
cvat-ui/src/components/cloud-storages-page/cloud-storages-page.tsx
Outdated
Show resolved
Hide resolved
added 2 commits
April 4, 2024 20:00
…m/syedbarimanjan/cvat into enhancement/empty-list-components
klakhov
approved these changes
Apr 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Fixes #7657 Made all of the empty-list components ui consistent.
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.