Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC2024] add test case for subsequent annotation import #7673

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

umangapatel123
Copy link
Contributor

Motivation and context

Test Case for the PR #7599 and Issue #7428

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Merging #7673 (522d48c) into develop (26750a9) will increase coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7673      +/-   ##
===========================================
+ Coverage    83.37%   83.39%   +0.02%     
===========================================
  Files          373      373              
  Lines        39744    39744              
  Branches      3745     3745              
===========================================
+ Hits         33137    33145       +8     
+ Misses        6607     6599       -8     
Components Coverage Δ
cvat-ui 79.23% <ø> (+0.04%) ⬆️
cvat-server 87.24% <ø> (ø)

@nmanovic nmanovic requested review from novda and removed request for azhavoro March 25, 2024 11:08
});

it('Export Annotation to the cloud storage', () => {
cy.clickInTaskMenu('Export task dataset', true, taskName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There a little bit repeating code in export task datasets. You can use the exportTask from here for exporting task datasets.

It seems the exportTask command need modify in export to the cloud storage, if you have the opportunity, let's fix it and be DRY :)

cy.waitForFileUploadToCloudStorage();
});

it('Import Annotation from the local storage', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in the import datasets, you can use uploadAnnotations from commands

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using the uploadAnnotations but the problem is that uploadAnnotations is made assuming the annotation is uploaded from the jobs page. so the GET request is intercepted and checked it's status but if you upload annotation from the tasks page, there is no GET request. It only does POST and PUT requests. Hence I have not used uploadAnnotations but tried to write modularized code.

umangapatel123 and others added 2 commits March 26, 2024 00:04
used `exportTask` from `commands.js` and made a common function for Import Annotation
@umangapatel123
Copy link
Contributor Author

umangapatel123 commented Mar 26, 2024

@novda can you please review it?

@umangapatel123
Copy link
Contributor Author

@novda any suggestion, please? I don't know why the check is failing for rest_api_testing.

@novda
Copy link
Contributor

novda commented Mar 28, 2024

@umangapatel123 There were some minor problems in ci/cd, now it's okay. Thanks for the contributing!

@novda novda merged commit 6273b48 into cvat-ai:develop Mar 28, 2024
34 checks passed
@umangapatel123 umangapatel123 deleted the import_annotation_filename_test branch March 29, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants