-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC2024] add test case for subsequent annotation import #7673
[GSoC2024] add test case for subsequent annotation import #7673
Conversation
test case for the pr cvat-ai#7599
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7673 +/- ##
===========================================
+ Coverage 83.37% 83.39% +0.02%
===========================================
Files 373 373
Lines 39744 39744
Branches 3745 3745
===========================================
+ Hits 33137 33145 +8
+ Misses 6607 6599 -8
|
}); | ||
|
||
it('Export Annotation to the cloud storage', () => { | ||
cy.clickInTaskMenu('Export task dataset', true, taskName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There a little bit repeating code in export task datasets. You can use the exportTask
from here for exporting task datasets.
It seems the exportTask
command need modify in export to the cloud storage, if you have the opportunity, let's fix it and be DRY :)
cy.waitForFileUploadToCloudStorage(); | ||
}); | ||
|
||
it('Import Annotation from the local storage', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also in the import datasets, you can use uploadAnnotations
from commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried using the uploadAnnotations
but the problem is that uploadAnnotations
is made assuming the annotation is uploaded from the jobs page. so the GET request is intercepted and checked it's status but if you upload annotation from the tasks page, there is no GET request. It only does POST and PUT requests. Hence I have not used uploadAnnotations
but tried to write modularized code.
used `exportTask` from `commands.js` and made a common function for Import Annotation
@novda can you please review it? |
@novda any suggestion, please? I don't know why the check is failing for |
@umangapatel123 There were some minor problems in ci/cd, now it's okay. Thanks for the contributing! |
Motivation and context
Test Case for the PR #7599 and Issue #7428
How has this been tested?
Checklist
develop
branch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.