[Hotfix] Fix scope defining #8185
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent changes in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- cvat/apps/engine/permissions.py (4 hunks)
Additional comments not posted (4)
cvat/apps/engine/permissions.py (4)
482-482: Verify the change of HTTP method forexport_dataset_v2.The HTTP method for
export_dataset_v2has been changed fromGETtoPOST. Ensure that all calls to this endpoint are updated accordingly in the codebase and that the change aligns with the expected behavior.Verification successful
Verification successful for the change of HTTP method for
export_dataset_v2.The HTTP method for
export_dataset_v2has been correctly updated toPOSTin the codebase. No instances of other HTTP methods were found for this endpoint.
cvat/apps/engine/permissions.py: Theexport_dataset_v2endpoint is mapped to thePOSTmethod.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `export_dataset_v2` match the new HTTP method. # Test: Search for the function usage. Expect: Only occurrences of the new HTTP method. rg --type python -A 5 $'export_dataset_v2'Length of output: 72
Script:
#!/bin/bash # Description: Verify all function calls to `export_dataset_v2` match the new HTTP method. # Test: Search for the function usage. Expect: Only occurrences of the new HTTP method. rg -A 5 'export_dataset_v2'Length of output: 2152
Script:
#!/bin/bash # Description: Verify that all calls to the `export_dataset_v2` endpoint use the `POST` method. # Test: Search for HTTP method usage of `export_dataset_v2`. Expect: Only occurrences of `POST`. rg -A 5 'export_dataset_v2' | grep -E 'GET|POST|PUT|DELETE|PATCH'Length of output: 1435
279-279: Verify the change of HTTP method forexport_backup_v2.The HTTP method for
export_backup_v2has been changed fromGETtoPOST. Ensure that all calls to this endpoint are updated accordingly in the codebase and that the change aligns with the expected behavior.Verification successful
Verification successful: The HTTP method for
export_backup_v2has been correctly updated toPOSTin all relevant parts of the codebase.
cvat/apps/engine/permissions.pycorrectly mapsexport_backup_v2toPOST.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `export_backup_v2` match the new HTTP method. # Test: Search for the function usage. Expect: Only occurrences of the new HTTP method. rg --type python -A 5 $'export_backup_v2'Length of output: 71
Script:
#!/bin/bash # Description: Verify all function calls to `export_backup_v2` match the new HTTP method. # Test: Search for the function usage. Expect: Only occurrences of the new HTTP method. rg -A 5 'export_backup_v2'Length of output: 1411
Script:
#!/bin/bash # Description: Verify all HTTP method usages for `export_backup_v2` are using POST. # Test: Search for HTTP method usages. Expect: Only occurrences of POST. rg -A 5 'export_backup_v2' | grep -i 'post'Length of output: 326
277-277: Verify the change of HTTP method forexport_dataset_v2.The HTTP method for
export_dataset_v2has been changed fromGETtoPOST. Ensure that all calls to this endpoint are updated accordingly in the codebase and that the change aligns with the expected behavior.Verification successful
Verification successful for the HTTP method change for
export_dataset_v2.The HTTP method for
export_dataset_v2has been changed fromGETtoPOST. The method implementation inmixins.pyis compatible with this change and does not explicitly depend on the HTTP method. Ensure that any external calls to this endpoint are updated accordingly.
cvat/apps/engine/permissions.py: Line 277cvat/apps/engine/mixins.py: Lines 466-473Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `export_dataset_v2` match the new HTTP method. # Test: Search for the function usage. Expect: Only occurrences of the new HTTP method. rg --type python -A 5 $'export_dataset_v2'Length of output: 72
Script:
#!/bin/bash # Description: Verify all function calls to `export_dataset_v2` match the new HTTP method. # Test: Search for the function usage. Expect: Only occurrences of the new HTTP method. rg --type py -A 5 $'export_dataset_v2'Length of output: 2162
Script:
#!/bin/bash # Description: Extract the implementation of the `export_dataset_v2` method from `mixins.py`. # Test: Retrieve the method implementation. Expect: Full method definition for review. ast-grep --lang python --pattern $'def export_dataset_v2(self, $_, $_):\n $$$' cvat/apps/engine/mixins.pyLength of output: 782
494-494: Verify the change of HTTP method forexport_backup_v2.The HTTP method for
export_backup_v2has been changed fromGETtoPOST. Ensure that all calls to this endpoint are updated accordingly in the codebase and that the change aligns with the expected behavior.Verification successful
Verified the change of HTTP method for
export_backup_v2.The HTTP method for
export_backup_v2has been correctly updated toPOSTin the permissions file. No direct HTTP calls or URL patterns were found referencing this endpoint, indicating it is likely called internally within the application.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `export_backup_v2` match the new HTTP method. # Test: Search for the function usage. Expect: Only occurrences of the new HTTP method. rg --type python -A 5 $'export_backup_v2'Length of output: 71
Script:
#!/bin/bash # Description: Verify all function calls to `export_backup_v2` match the new HTTP method. # Test: Search for the function usage. Expect: Only occurrences of the new HTTP method. rg --type py -A 5 $'export_backup_v2'Length of output: 1421
Script:
#!/bin/bash # Description: Verify all HTTP method calls to `export_backup_v2` match the new POST method. # Test: Search for HTTP method usage. Expect: Only occurrences of the new POST method. rg --type py -A 5 'export_backup_v2'Length of output: 1421
Script:
#!/bin/bash # Description: Verify all HTTP calls to `export_backup_v2` match the new POST method. # Test: Search for HTTP calls to `export_backup_v2`. Expect: Only occurrences of the new POST method. rg --type py -A 5 'export_backup_v2' | grep -E 'requests\.post|requests\.get|requests\.put|requests\.delete|requests\.patch'Length of output: 124
Script:
#!/bin/bash # Description: Verify all URL patterns and API routes that reference `export_backup_v2`. # Test: Search for URL patterns and API routes. Expect: Only occurrences referencing `export_backup_v2`. rg --type py 'export_backup_v2'Length of output: 313
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8185 +/- ##
===========================================
+ Coverage 83.35% 83.37% +0.01%
===========================================
Files 388 388
Lines 41306 41306
Branches 3854 3854
===========================================
+ Hits 34432 34439 +7
+ Misses 6874 6867 -7
|
|
LGTM, but need to add a test, probably in a separate PR |
|
Also please add a changelog entry |
|
I was sure that we have such tests, probably the previous version of API was used there, I'll check |
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Bug Fixes
export_dataset_v2andexport_backup_v2endpoints to usePOSTinstead ofGETfor improved security and functionality.Improvements