-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update datumaro version #8262
Update datumaro version #8262
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent updates involve changing the version of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- cvat/requirements/base.in (1 hunks)
- cvat/requirements/base.txt (1 hunks)
Additional comments not posted (2)
cvat/requirements/base.in (1)
9-9
: Verify thedatumaro
package update.Ensure that the new commit hash
04832fb0bd2b54ed4f32887a8720dc8cc933119d
is correct and compatible with the project.Verification successful
The
datumaro
package update to commit hash04832fb0bd2b54ed4f32887a8720dc8cc933119d
is verified.The commit exists and includes relevant fixes and improvements.
- Commit hash:
04832fb0bd2b54ed4f32887a8720dc8cc933119d
- Commit message: "Fix collision in LabelCategories._indices (Data validation on client and server #51)"
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the `datumaro` package update. # Test: Check if the new commit hash exists in the `datumaro` repository. # Expect: The commit hash should exist and be valid. gh api -H "Accept: application/vnd.github.v3+json" /repos/cvat-ai/datumaro/commits/04832fb0bd2b54ed4f32887a8720dc8cc933119dLength of output: 26713
cvat/requirements/base.txt (1)
60-60
: Verify thedatumaro
package update.Ensure that the new commit hash
04832fb0bd2b54ed4f32887a8720dc8cc933119d
is correct and compatible with the project.
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8262 +/- ##
===========================================
+ Coverage 83.32% 83.36% +0.04%
===========================================
Files 388 389 +1
Lines 41395 41526 +131
Branches 3856 3856
===========================================
+ Hits 34491 34620 +129
- Misses 6904 6906 +2
|
### Motivation and context This PR is an addition to #8262 and cvat-ai/datumaro#51. It modifies existing test data adding specific case where label names and their keypoints collide in a specific way (label = "name" and keypoint = "22", label = "name2" and keypoint = "2"). The file is used in `cvat.apps.dataset_manager.tests.test_rest_api_formats.ProjectDumpUpload.test_api_v2_export_import_dataset`. Running this test with these changes and older version of datumaro (`datumaro @ git+https://github.com/cvat-ai/datumaro.git@2a4d9dbbd86f2e5fc5f8db2cfd2defdf464e9645`) will result in `AssertionError`. ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new "sublabels" section to enhance data categorization with 22 entries, improving user interaction and annotation processes. - Expanded the "svg" attribute for better visual representation of dataset elements, facilitating clearer insights into their relationships. - Updated the existing skeleton entry to consistently include a "sublabels" section, reinforcing coherence in the dataset configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
Motivation and context
See cvat-ai/datumaro#51
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
datumaro
package to a newer version, which may include new features and improvements.