Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datumaro version #8262

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Update datumaro version #8262

merged 5 commits into from
Aug 6, 2024

Conversation

Bobronium
Copy link
Member

@Bobronium Bobronium commented Aug 6, 2024

Motivation and context

See cvat-ai/datumaro#51

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • Dependency Updates
    • Updated the datumaro package to a newer version, which may include new features and improvements.

Copy link
Contributor

coderabbitai bot commented Aug 6, 2024

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates involve changing the version of the datumaro package in the cvat project from an older commit to a newer one. This transition aims to leverage enhancements, bug fixes, or new features available in the updated datumaro repository, potentially impacting the application's functionality. Both base.in and base.txt files reflect this change, ensuring consistency in dependency management across different environments.

Changes

Files Change Summary
cvat/requirements/base.in Updated datumaro version from commit 2a4d9dbb... to 04832fb0....
cvat/requirements/base.txt Updated datumaro version from commit 2a4d9dbb... to 04832fb0....

Poem

🐰 In the code where rabbits hop,
Changes made, we’ll never stop!
Datumaro's new commit shines bright,
Enhancing features, what a delight!
Bugs be gone, let’s dance with glee,
Hopping forward, code sets us free! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f3dcc3e and a92e39e.

Files selected for processing (2)
  • cvat/requirements/base.in (1 hunks)
  • cvat/requirements/base.txt (1 hunks)
Additional comments not posted (2)
cvat/requirements/base.in (1)

9-9: Verify the datumaro package update.

Ensure that the new commit hash 04832fb0bd2b54ed4f32887a8720dc8cc933119d is correct and compatible with the project.

Verification successful

The datumaro package update to commit hash 04832fb0bd2b54ed4f32887a8720dc8cc933119d is verified.

The commit exists and includes relevant fixes and improvements.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the `datumaro` package update.

# Test: Check if the new commit hash exists in the `datumaro` repository.
# Expect: The commit hash should exist and be valid.
gh api -H "Accept: application/vnd.github.v3+json" /repos/cvat-ai/datumaro/commits/04832fb0bd2b54ed4f32887a8720dc8cc933119d

Length of output: 26713

cvat/requirements/base.txt (1)

60-60: Verify the datumaro package update.

Ensure that the new commit hash 04832fb0bd2b54ed4f32887a8720dc8cc933119d is correct and compatible with the project.

Copy link

sonarcloud bot commented Aug 6, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (f3dcc3e) to head (a980d78).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8262      +/-   ##
===========================================
+ Coverage    83.32%   83.36%   +0.04%     
===========================================
  Files          388      389       +1     
  Lines        41395    41526     +131     
  Branches      3856     3856              
===========================================
+ Hits         34491    34620     +129     
- Misses        6904     6906       +2     
Components Coverage Δ
cvat-ui 79.64% <ø> (+<0.01%) ⬆️
cvat-server 86.67% <ø> (+0.06%) ⬆️

@zhiltsov-max zhiltsov-max merged commit a1b6904 into develop Aug 6, 2024
33 checks passed
@cvat-bot cvat-bot bot mentioned this pull request Aug 6, 2024
zhiltsov-max added a commit that referenced this pull request Aug 12, 2024
### Motivation and context
This PR is an addition to #8262 and
cvat-ai/datumaro#51.

It modifies existing test data adding specific case where label names
and their keypoints collide in a specific way (label = "name" and
keypoint = "22", label = "name2" and keypoint = "2").

The file is used in
`cvat.apps.dataset_manager.tests.test_rest_api_formats.ProjectDumpUpload.test_api_v2_export_import_dataset`.
Running this test with these changes and older version of datumaro
(`datumaro @
git+https://github.com/cvat-ai/datumaro.git@2a4d9dbbd86f2e5fc5f8db2cfd2defdf464e9645`)
will result in `AssertionError`.


### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new "sublabels" section to enhance data categorization
with 22 entries, improving user interaction and annotation processes.
- Expanded the "svg" attribute for better visual representation of
dataset elements, facilitating clearer insights into their
relationships.
- Updated the existing skeleton entry to consistently include a
"sublabels" section, reinforcing coherence in the dataset configuration.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
@bsekachev bsekachev deleted the ba/update-datumaro-version branch August 12, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants