Fixed undefined active control

[bsekachev]

Motivation and context

How has this been tested?

Checklist

• I submit my changes into the develop branch
• I have created a changelog fragment
• I have updated the documentation accordingly
• I have added tests to cover my changes
• I have linked related issues (see GitHub docs)
• I have increased versions of npm packages if it is necessary
  (cvat-canvas,
  cvat-core,
  cvat-data and
  cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

• Bug Fixes

  • Resolved an issue with workspace switching that caused the active control to become unresponsive after creating a tag using a keyboard shortcut, improving user experience.

• Enhancements

  • Improved control flow by refining the assignment of the activeControl variable based on the active object type, enhancing the behavior of the tagging feature.

[coderabbitai]

Walkthrough

This update resolves a bug related to workspace switching and tagging functionality in the application. A specific control flow adjustment was made to enhance the behavior of the repeatDrawShapeAsync function, ensuring that the assignment of the activeControl variable is now conditional based on the active object type. These changes collectively improve user experience when interacting with tags and workspace transitions.

Changes

Files	Change Summary
changelog.d/20240822_111601_sekachev.bs_fixed_minor_issue.md	Fixes a bug where the active control becomes unresponsive when creating a tag with a keyboard shortcut.
cvat-ui/src/actions/annotation-actions.ts	Adds a conditional check in repeatDrawShapeAsync to modify when activeControl is assigned based on object type.

Poem

In the workspace, hopping free,
Tags now dance with glee! 🐇✨
Controls that once went awry,
Now glide smoothly, oh my!
A little fix, a joyful cheer,
Happy tagging, far and near!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

changelog.d/20240822_111601_sekachev.bs_fixed_minor_issue.md (1)

3-4: Improve clarity of the changelog entry.

Consider rephrasing the changelog entry for better clarity:

- Sometimes it is not possible to switch workspace because active control broken after 
- trying to create a tag with a shortcut (<https://github.com/cvat-ai/cvat/pull/8334>)
+ Fixed an issue where switching workspaces was sometimes impossible due to a broken active control after attempting to create a tag using a shortcut. See the related PR: <https://github.com/cvat-ai/cvat/pull/8334>

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3fdb032 and 01de79f.

Files selected for processing (2)

• changelog.d/20240822_111601_sekachev.bs_fixed_minor_issue.md (1 hunks)
• cvat-ui/src/actions/annotation-actions.ts (1 hunks)

Additional comments not posted (1)

cvat-ui/src/actions/annotation-actions.ts (1)

1415-1417: Conditional assignment of activeControl is correct.

The conditional check ensures that activeControl is only assigned when activeObjectType is not a tag. This change aligns with the intended fix to prevent issues with undefined active controls.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (3fdb032) to head (01de79f).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8334      +/-   ##
===========================================
- Coverage    83.57%   83.56%   -0.02%     
===========================================
  Files          393      393              
  Lines        41608    41609       +1     
  Branches      3843     3844       +1     
===========================================
- Hits         34775    34770       -5     
- Misses        6833     6839       +6     

Components	Coverage Δ
cvat-ui	79.62% <100.00%> (-0.03%)	⬇️
cvat-server	87.05% <ø> (ø)