Ignore onTabUpdated events for unknown tabs

Fixes #237
cxw42 · Dec 25, 2020 · f779c3e · f779c3e
1 parent 89c7341
commit f779c3e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/settings/manifest.js b/app/settings/manifest.js
@@ -514,7 +514,7 @@ recovered window will show up in TabFern as a separate, unsaved window
     listed in the title bar.  This will make it easier to reference the
     commit in bug reports.  ${issue(210)}</li>
 <li>Fix broken image links in README.md.  Thanks, @bluikko!  ${issue(224)}</li>
-<li>Misc: ${issue([233, 236], true)}</li>
+<li>Misc: ${issue([233, 236, 237], true)}</li>
 ` +
 '</ul>'
             ),

diff --git a/app/win/model.js b/app/win/model.js
@@ -1175,7 +1175,11 @@ me.react_onTabUpdated = function(ctabid, changeinfo, newctab) {
     let should_refresh_icon = false;
 
     let tabvn = me.vn_by_cid(ctabid, K.IT_TAB);
-    if(!tabvn.val) return `Tab ${ctabid} not found`;
+    if(!tabvn.val) {
+        // We've probably already closed this tab, so drop this change (#237).
+        log.info(`Ignoring tabUpdated event for unknown tab ${ctabid}`);
+        return {dirty: false};
+    }
 
     let node = T.treeobj.get_node(tabvn.node_id);
     if(!node) return `No node for ID ${tabvn.node_id} (${JSON.stringify(tabvn)})`;