Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toyota: the smoothest longitudinal you will ever see #15

Closed
wants to merge 169 commits into from
Closed

Toyota: the smoothest longitudinal you will ever see #15

wants to merge 169 commits into from

Conversation

cydia2020
Copy link
Owner

@cydia2020 cydia2020 commented Dec 12, 2023 •
edited
Loading

fixed:

  1. abrupt stopping on Toyota, now you can feel the stop braking
  2. no more longitudinal deadzones needed
  3. complicated starting logic
  4. no more different tuning for different vehicles
  5. no more cruising just below set speed when going downhill
  6. no more unresponsive highway speed control
  7. no more engine revving
  8. no more slow accel request response

need to verify:

  • a nicer decel rate
  • a nicer speed at which to enter stopping state

Comma Device and others added 30 commits December 7, 2023 00:45
bump opendbc
96f5057
Toyota: compensate for pcm neutral force
363876f
@cydia2020
use self.engineRpm
d74fb00
@cydia2020
use CS.engineRpm
f25cc69
don't account for engine rpm
f7071a6
@cydia2020
Toyota: handle pcm accel explicitly
7bdef02
@cydia2020
try a more aggressive tune
8fecf1a
Revert "try a more aggressive tune"
754f8c0 
This reverts commit 8fecf1a.
@cydia2020
reinstate camry max accel
4974c6f
@cydia2020
transition from driver accel to op accel
587723d
@cydia2020
Update opendbc
fcd878f
@cydia2020
transition the force instead
d45968e
@cydia2020
basic pitch compensation
7923b41
@cydia2020
progressively complicated carcontroller
de91696
@cydia2020
dont know the frequency of this
cdd8780
@cydia2020
should be <
e762867 
also better naming for var
@cydia2020
remove permit braking logic
ff94452
@cydia2020
remove pitch compensation
89bb64d
@cydia2020
start with 0 force
69a6297
@cydia2020
enable stopping control
3206b55
@cydia2020
remove comment
ee3bf62
@cydia2020
Revert "remove comment"
f78a4d4 
This reverts commit ee3bf62.
@cydia2020
Revert "enable stopping control"
5030d78 
This reverts commit 3206b55.
@cydia2020
enter stopping state sooner on toyota
9ee4a76
@cydia2020
give toyota cc stopping state
10c32f6
@cydia2020
perform_force_transition -> perform_enablement_force_transition
453e611
@cydia2020
add a stopping force transition
46fe717
@cydia2020
fix comment
47fa779
@cydia2020
oops conversion
91a784d
@cydia2020
use v_ego for clearer understanding
2971137
Comma Device and others added 26 commits January 21, 2024 09:56
rework logic
f05cd4b
@cydia2020
more comments
987358f
@cydia2020
simpler
ab5f5da
@cydia2020
test if this makes any difference
e66a217
@cydia2020
start compensating earlier
d40a261
@cydia2020
fix misspelling
da8a42c
@cydia2020
0.15 is a bit too slow
58c0a28
@cydia2020
prohibit accel when lead is stopped
a7a7148
@cydia2020
Revert "prohibit accel when lead is stopped"
f025b7c 
This reverts commit a7a7148.
@cydia2020
dont compensate when stopped
983fc8f
@cydia2020
bump opendbc
546187f
@cydia2020
is this what I think it is?
acac587
@cydia2020
"starts requesting brake when aEgo is generally high"
4fb7501 
?
@cydia2020
permit braking condition
e793f30
@cydia2020
acceleration continuation decision?
f4df903
@cydia2020
spam cancel?
8688ded
@cydia2020
bump submodules
bcf2e4d
@cydia2020
Revert "bump submodules"
f8a1a46 
This reverts commit bcf2e4d.
@cydia2020
Revert "spam cancel?"
ed4d5e8 
This reverts commit 8688ded.
@cydia2020
Revert "acceleration continuation decision?"
53a92c2 
This reverts commit f4df903.
@cydia2020
Revert "permit braking condition"
c2be664 
This reverts commit e793f30.
@cydia2020
Revert ""starts requesting brake when aEgo is generally high""
cc22e8d 
This reverts commit 4fb7501.
@cydia2020
Revert "is this what I think it is?"
7ef9e74 
This reverts commit acac587.
@cydia2020
Revert "bump opendbc"
2e2d857 
This reverts commit 546187f.
@cydia2020
Revert "dont compensate when stopped"
f5f6a06 
This reverts commit 983fc8f.
@cydia2020
dsu reroute harness
444df89
@github-actions GitHub Actions
Copy link

This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions bot added the Stale label Apr 12, 2024
@github-actions GitHub Actions
Copy link

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cydia2020