include a description of WORKFLOW_SHARE_DIR/bin and lib/python #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
feature.support_share/bin_and_share/lib
branch
from
add9c45
to
3543dee
Compare
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
8 tasks
hjoliver
requested changes
May 12, 2023
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
hjoliver
approved these changes
May 14, 2023
MetRonnie
reviewed
May 22, 2023
Comment on lines
338
to
339
| These locations will be placed first in the executable and Python module | ||
| search paths, before those in the parent run directory . |
There was a problem hiding this comment.
Maybe
Suggested change
| These locations will be placed first in the executable and Python module | |
| search paths, before those in the parent run directory . | |
| These locations take precedence over the top level ``bin/`` and | |
| ``lib/python/`` directories in the run dir. |
There was a problem hiding this comment.
@wxtim and @MetRonnie - this kind of reverses my 2nd review suggestion above. I would prefer to just "state the facts" here, which is where these directories are put in the search paths. "Take precedence" or "called first" (Tim's original phrasing) could be assumed to have wider implications, e.g. for how Cylc itself somehow uses these locations.
There was a problem hiding this comment.
I rather agree with Hilary - can we come to a conclusion @MetRonnie ?
There was a problem hiding this comment.
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
reviewed
May 22, 2023
wxtim
commented
May 23, 2023
MetRonnie
reviewed
May 31, 2023
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
…wxtim/cylc-doc into feature.support_share/bin_and_share/lib * 'feature.support_share/bin_and_share/lib' of github.com:wxtim/cylc-doc: Update src/user-guide/writing-workflows/runtime.rst Update src/user-guide/installing-workflows.rst Apply suggestions from code review Update src/user-guide/writing-workflows/runtime.rst Update src/user-guide/writing-workflows/runtime.rst Update src/user-guide/writing-workflows/runtime.rst Apply suggestions from code review add some extra links Update src/user-guide/writing-workflows/configuration.rst
MetRonnie
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanies changes to cylc/cylc-flow#5525
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.