Merge pull request #6024 from cylc/8.2.x-sync

🤖 Merge 8.2.x-sync into master

changes.d/6011.fix.md

@@ -0,0 +1 @@
+Fixed a `cylc vip` bug causing remote re-invocation to fail if using `--workflow-name` option.

cylc/flow/option_parsers.py

@@ -790,9 +790,9 @@ def cleanup_sysargv(
     new_args[1] = script_name
 
     # replace source path with workflow ID.
-    if str(source) in sys.argv:
+    if str(source) in new_args:
         new_args.remove(str(source))
-    if workflow_id not in sys.argv:
+    if workflow_id not in new_args:
         new_args.append(workflow_id)
 
     sys.argv = new_args

tests/unit/test_option_parsers.py

@@ -383,6 +383,22 @@ def test_combine_options(inputs, expect):
             'play --foo something myworkflow'.split(),
             id='no path given'
         ),
+        param(
+            'vip -n myworkflow --no-run-name'.split(),
+            {
+                'script_name': 'play',
+                'workflow_id': 'myworkflow',
+                'compound_script_opts': [
+                    OptionSettings(['--workflow-name', '-n']),
+                    OptionSettings(['--no-run-name']),
+                ],
+                'script_opts': [
+                    OptionSettings(['--not-used']),
+                ]
+            },
+            'play myworkflow'.split(),
+            id='workflow-id-added'
+        ),
     ]
 )
 def test_cleanup_sysargv(monkeypatch, argv_before, kwargs, expect):

tox.ini

@@ -11,8 +11,6 @@ ignore=
     ; suggests using f"{!r}" instead of manual quotes (flake8-bugbear)
     ; Doesn't work at 3.7
     B028
-    ; Broken in two cases https://github.com/PyCQA/flake8-bugbear/issues/451
-    B038
 
 exclude=
     build,