Skip to content

Commit

Permalink
review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
oliver-sanders committed Apr 25, 2024
1 parent a88733a commit a41cd9d
Showing 1 changed file with 22 additions and 14 deletions.
36 changes: 22 additions & 14 deletions cylc/flow/cfgspec/workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -1083,38 +1083,46 @@ def get_script_common_text(this: str, example: Optional[str] = None):
foo:x? => x
In these cases succeess is presumed to be required unless
explicitly stated otherwise, either in the graph:
explicitly stated otherwise, either in the graph e.g:
.. code-block:: cylc-graph
foo?
foo:x? => x
Or in the completion expression:
Or in the completion expression e.g:
.. code-block:: cylc
completion = x # no reference to succeeded here
completion = x # no reference to succeeded
# or
completion = succeeded or failed # success is optional
.. hint::
If task outputs are optional in the graph they must also
be optional in the completion condition and vice versa.
For example this graph conflicts with the completion
statement:
.. code-block:: cylc-graph
# "a" must succeed
a => b
.. code-block:: cylc
[scheduling]
[[graph]]
R1 = """
# ERROR: this should be "a? => b"
a => b
"""
[runtime]
[[a]]
# this completion condition implies that the
# succeeded output is optional
completion = succeeded or failed
# "a" may either succeed or fail
completion = succeeded or failed
Which could be fixed by ammending the graph like so:
.. code-block:: cylc-graph
# "a" may either succeed or fail
a? => b
.. rubric:: Examples
Expand Down

0 comments on commit a41cd9d

Please sign in to comment.