cylc validate: fix failure on XXX-FAM task name #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1400,7 +1400,12 @@ def process_graph_line(self, line, section, seq, offset_seq_map, | |||
| # backslashed re markers like \b from being interpreted as | |||
| # normal escapeded characters. | |||
|
|
|||
| if fam not in line: | |||
| fam_in_line = re.search( | |||
| r"(?<!%(name_char_re)s)%(fam)s(?!(name_char_re)s)" % { | |||
There was a problem hiding this comment.
Missing '%' in the second name_char_re string template!
There was a problem hiding this comment.
Fixed, and added extra test.
See cylc#1778 for detail.
matthewrmshin
force-pushed
the
fix-validate-hyphen-fam-name-failure
branch
from
107d2a8
to
47cca5a
Compare
|
Branch re-based. |
|
Review 1 - good, tests pass. |
|
Looks good to me. Test battery passing in my environment as is manual testing with the example in #1778. |
matthewrmshin
added a commit
to matthewrmshin/cylc-flow
that referenced
this pull request
Apr 27, 2016
It was attempted in cylc#1779 but the fix had a speed issue. This attempt improves the speed and reduces the complexity of the original fix.
matthewrmshin
added a commit
to matthewrmshin/cylc-flow
that referenced
this pull request
Apr 27, 2016
It was attempted in cylc#1779 but the fix had a speed issue. This attempt improves the speed and reduces the complexity of the original fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1778.