Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nudge insert #1855

Merged
merged 1 commit into from
May 24, 2016
Merged

Nudge insert #1855

merged 1 commit into from
May 24, 2016

Conversation

matthewrmshin
Copy link
Contributor

By moving the logic to process the command queue to an earlier position
in the main loop.

Allow an inserted task to be released from the runahead pool so that it
is listed as a waiting task by the GUI. Previously, it would be listed
as a runahead task, and a nudge would be needed to release it to the
pool.

@hjoliver @benfitzpatrick please review.

By moving the logic to process the command queue to an earlier position
in the main loop.

Allow an inserted task to be released from the runahead pool so that it
is listed as a waiting task by the GUI. Previously, it would be listed
as a runahead task, and a nudge would be needed to release it to the
pool.
@matthewrmshin matthewrmshin added this to the next release milestone May 23, 2016
@matthewrmshin
Copy link
Contributor Author

Not sure how to create an automated test for this because as soon as we talk to the suite, it fixes itself. I tested the change with this suite:

[scheduling]
    [[special tasks]]
        exclude at start-up = t2
    [[dependencies]]
        graph = 't1 => t2'
[runtime]
    [[t1]]
        script = sleep 120
    [[t2]]
        script = true
  1. Run the suite.
  2. Start GUI.
  3. Insert t2.1 via CLI or GUI.
  4. Look at the change in the GUI.

On master, the task will have the runahead status (and will get itself filtered out by default).
On this branch, the task will have the waiting status.

Test battery passes in my environment.

@hjoliver
Copy link
Member

Thanks for this - I had noticed it myself a while back but forgot to deal with it.

Review 1 - good, all tests pass.

@hjoliver hjoliver assigned benfitzpatrick and unassigned hjoliver May 23, 2016
@benfitzpatrick benfitzpatrick merged commit ab480f2 into cylc:master May 24, 2016
@matthewrmshin matthewrmshin deleted the nudge-insert branch May 24, 2016 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants