Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

601: gscan groups #2024

Merged
merged 8 commits into from
Nov 17, 2016
Merged

601: gscan groups #2024

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
072b8da
basic group functionality implemented.
arjclark Oct 4, 2016
62a01cf
Fix missing key error.
arjclark Nov 9, 2016
a46133f
Fix pep8
arjclark Nov 9, 2016
bd96165
Fix black boxes and missing info.
arjclark Nov 10, 2016
1c17131
pep8 fix.
arjclark Nov 10, 2016
ae8701e
Review feedback.
arjclark Nov 10, 2016
1a0f302
Merge remote branch 'upstream/master' into 601b.gscan_groups
arjclark Nov 17, 2016
7030712
Add test and set default as "(ungrouped)"
arjclark Nov 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review feedback.
  • Loading branch information
@arjclark
arjclark committed Nov 10, 2016
commit ae8701eab2c099f98aed8dd786d14ca13ce9a32f
3 changes: 1 addition & 2 deletions lib/cylc/gui/gscan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,7 +1183,7 @@ def update(self):

group = suite_info.get("group")
if group is None:
group = ""
group = "ungrouped"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if a string like (default) is better here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "ungrouped" is clearer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case, can we do (ungrouped) in bracket to make it clearer that we have not got a group called ungrouped?


if 'tasks-by-state' in suite_info:
self.tasks_by_state[(suite, host)] = suite_info[
Expand Down Expand Up @@ -1227,7 +1227,6 @@ def update(self):
if state != TASK_STATUS_RUNAHEAD:
# 'runahead' states are usually hidden.
states_text += '%s %d ' % (state, number)
# Extractable counts here?
if not states_text:
# Purely runahead cycle.
continue
Expand Down