Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: don't warn on connection error #2032

Conversation

matthewrmshin
Copy link
Contributor

The pop up warning dialog can be very annoying on suite start up and
automatic shut down. Now that we have the connection count down, we
don't really need to use the warning dialog on connection error.

Equivalence of #2021, but for 6.11.x.

The pop up warning dialog can be very annoying on suite start up and
automatic shut down. Now that we have the connection count down, we
don't really need to use the warning dialog on connection error.
@matthewrmshin
Copy link
Contributor Author

@hjoliver @oliver-sanders please review.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests as working.

@oliver-sanders oliver-sanders merged commit 7d7d6bf into cylc:6.11.x Oct 11, 2016
@matthewrmshin matthewrmshin deleted the 6.11.x-gui-dont-warn-on-connection-error branch October 11, 2016 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants