Fix submitted/running task owner/host on restart #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
force-pushed
the
fix-restart-task-owner-host
branch
5 times, most recently
from
bd3361c
to
aaceeeb
Compare
oliver-sanders
approved these changes
Jan 4, 2017
hjoliver
requested changes
Jan 7, 2017
| kwargs["host"] = host | ||
| except IOError: | ||
| # Bad host, run the command any way, command will fail and | ||
| # callback with due with it |
Ensure that `itask.task_owner` and `itask.task_host` are set on restart. Previously, it only sets `itask.user_at_host` which is not enough for job management commands such as poll/kill. Remove `TaskProxy.user_at_host` as an attribute, as it duplicates the functionality of `TaskProxy.task_owner` and `TaskProxy.task_host` and confuses matter. Also fix diagnostic log after successful kill - it should not say retry after P0Y.
matthewrmshin
force-pushed
the
fix-restart-task-owner-host
branch
from
aaceeeb
to
aa61884
Compare
|
Comment fixed, branch rebased and squashed. |
hjoliver
approved these changes
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
itask.task_owneranditask.task_hostare set on restart.Previously, it only set
itask.user_at_hostwhich was not enough forjob management commands such as poll/kill.
Remove
TaskProxy.user_at_hostas an attribute, as it duplicates thefunctionality of
TaskProxy.task_ownerandTaskProxy.task_hostandconfuses matter.
Also fix diagnostic log after successful kill - it should not say retry
after P0Y.