#1332: Implement auto use of cycle-point format in a remote suite. #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,6 +76,15 @@ def display_maps(self, res): | |||
| for row in res: | |||
| sys.stdout.write((", ").join(row).encode("utf-8") + "\n") | |||
|
|
|||
| def get_remote_point_format(self): | |||
There was a problem hiding this comment.
Should add doc string.
tests/suite-state/06-format.t
Outdated
| suite_run_ok $TEST_NAME cylc run --debug $SUITE_NAME | ||
| #------------------------------------------------------------------------------- | ||
| TEST_NAME=$TEST_NAME_BASE-cli-template | ||
| run_ok $TEST_NAME cylc suite-state $SUITE_NAME -p 20100101T0000Z \ |
There was a problem hiding this comment.
Maybe worth adding a test for STDOUT?
matthewrmshin
approved these changes
Jan 30, 2017
|
@matthewrmshin - comments addressed |
hjoliver
requested changes
Feb 7, 2017
lib/cylc/task_pool.py
Outdated
| @@ -1430,6 +1430,11 @@ def put_rundb_suite_params(self, initial_point, final_point): | |||
| {"key": "initial_point", "value": str(initial_point)}, | |||
| {"key": "final_point", "value": str(final_point)}, | |||
| ]) | |||
| if format: | |||
| print "during format thing" | |||
There was a problem hiding this comment.
Well spotted, fixed now.
|
@hjoliver - spurious print removed 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1332