Fix common name of SSL cert #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
reviewed
Mar 15, 2017
lib/cylc/suite_srv_files_mgr.py
Outdated
| @@ -464,11 +464,11 @@ def _get_ssl_cert(self, path, reg, pkey_obj): | |||
| # OpenSSL not installed, so we can't use HTTPS anyway. | |||
| return | |||
| # Use suite name as the 'common name', but no more than 64 chars. | |||
There was a problem hiding this comment.
Yes. Now fixed.
Use suite host name instead of suite name.
matthewrmshin
force-pushed
the
fix-ssl-cert-cn
branch
from
ee4a4fa
to
e59acb4
Compare
|
ssl.com FAQ "What is the common name": http://info.ssl.com/article.aspx?id=10048 |
hjoliver
approved these changes
Mar 16, 2017
|
The code looks fine. I suppose we don't need to worry about the problem (see FAQ URL above) with variant versions of the same host, because |
|
Yes. Clients will always use the host value in |
oliver-sanders
approved these changes
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use suite host name instead of suite name.