Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRITICAL event handler. #2304

Merged
merged 1 commit into from
May 24, 2017
Merged

Conversation

hjoliver
Copy link
Member

(separated from #2298)

@hjoliver hjoliver added this to the soon milestone May 24, 2017
@hjoliver
Copy link
Member Author

From the original issue #2298 (comment)

@matthewrmshin wrote:

If we have configured a failed handler and a critical handler, I guess both will run?

Yes, as implemented, critical handlers get all CRITICAL events. This seems logical to me, but obviously failed handlers will get many/most of the same events. This isn't necessarily a bad thing as critical and failed handlers could do different things. Alternatively we could pass only non-failure CRITICAL events to critical handlers. Or allow both options?

@matthewrmshin
Copy link
Contributor

Let's go with the simple implementation unless people scream.

@hjoliver
Copy link
Member Author

Ah, which is "the simple implementation" in your opinion? (as it is now?)

@matthewrmshin
Copy link
Contributor

As implemented is good enough unless people scream.

@hjoliver
Copy link
Member Author

OK, glad you agree 😁 I'll just add a test...

@hjoliver
Copy link
Member Author

(actually, I already added this to the existing test).

@hjoliver
Copy link
Member Author

@matthewrmshin - please assign a second reviewer.

@oliver-sanders oliver-sanders merged commit cfa52ea into cylc:master May 24, 2017
@hjoliver hjoliver deleted the critical-handler branch May 24, 2017 11:09
@matthewrmshin matthewrmshin modified the milestones: next release, soon May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants