-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRITICAL event handler. #2304
Conversation
From the original issue #2298 (comment) @matthewrmshin wrote:
Yes, as implemented, critical handlers get all CRITICAL events. This seems logical to me, but obviously failed handlers will get many/most of the same events. This isn't necessarily a bad thing as critical and failed handlers could do different things. Alternatively we could pass only non-failure CRITICAL events to critical handlers. Or allow both options? |
Let's go with the simple implementation unless people scream. |
Ah, which is "the simple implementation" in your opinion? (as it is now?) |
As implemented is good enough unless people scream. |
OK, glad you agree 😁 I'll just add a test... |
(actually, I already added this to the existing test). |
@matthewrmshin - please assign a second reviewer. |
(separated from #2298)