-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put suite metadata items in a meta section #2387
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
34146a7
Modified code to generalise suite details under meta section
challurip e0f958d
Modified to remove pep8 errors
challurip 871b3f3
Merge branch 'master' of https://github.com/cylc/cylc into suite-meta
challurip 3eae93b
To pass event tests
challurip e15f67f
pep8 errors
challurip 420f5ec
pep8 errors and registration test to pass
challurip d0f4d44
Merge branch 'master' of https://github.com/cylc/cylc into suite-meta
challurip 285165d
tests for suite meta
challurip 0a40240
cylc scan fix
challurip cf0b8f5
fix tests
challurip 646b96e
suite meta doc
challurip afc9b4b
allow plain URL
challurip deb5845
get suite meta items in task event handler
challurip 9d8d38a
pep8 errors
challurip 1d47e8d
minor changes in documentation
challurip 27fc52a
minor changes in doc
challurip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
minor changes in documentation
- Loading branch information
commit 1d47e8d68e71afc1f96e4b6d10ea492db333f319
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,13 +30,13 @@ \subsection{[meta]} | |
Section containing metadata items for this suite. Several items | ||
(title, description, URL) are pre-defined and are used by the GUI. Others can be | ||
user-defined and passed to suite event handlers to be interpreted according to your | ||
needs. For example, the value of an "suite-priority" item could determine how an event | ||
needs. For example, the value of a ``suite-priority'' item could determine how an event | ||
handler responds to failure events. | ||
|
||
|
||
\subsubsection[title]{ [meta] \textrightarrow title} | ||
|
||
A single line description of the suite. It is displayed in the db viewer | ||
A single line description of the suite. It is displayed in the GUI ``Open Another Suite'' | ||
window and can be retrieved at run time with the | ||
\lstinline=cylc show= command. | ||
|
||
|
@@ -47,8 +47,8 @@ \subsection{[meta]} | |
|
||
\subsubsection[description]{ [meta] \textrightarrow description} | ||
|
||
A multi-line description of the suite. It can be retrieved by the db viewer | ||
right-click menu, or at run time with the \lstinline=cylc show= command. | ||
A multi-line description of the suite. It can be retrieved at run time with the | ||
\lstinline=cylc show= command. | ||
|
||
\begin{myitemize} | ||
\item {\em type:} multi-line string | ||
|
@@ -342,7 +342,7 @@ \subsection{[cylc]} | |
\item \%(message)s: event message, if any | ||
\end{myitemize} | ||
|
||
Can also include the patterns from [meta] section of the suite, for example: | ||
It can also include the patterns from the [meta] section of the suite, for example: | ||
\begin{myitemize} | ||
\item \%(suite-priority)s: suite priority | ||
\item \%(color)s: suite color | ||
|
@@ -1267,7 +1267,17 @@ \subsection{[runtime]} | |
needs. For example, the value of an "importance" item could determine how an event | ||
handler responds to task failure events. | ||
|
||
\paragraph[title]{[runtime] \textrightarrow [[\_\_NAME\_\_]] \textrightarrow [[[meta]]] \textrightarrow title} | ||
Any suite meta item can now be passed to task event handlers by prefixing the | ||
string template item name with ``suite\_'', for example : | ||
|
||
\begin{lstlisting} | ||
[runtime] | ||
[[root]] | ||
[[[events]]] | ||
failed handler = send-help.sh %(suite\_title)s %(suite\_importance)s %(title)s | ||
\end{lstlisting} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Underscores shouldn't be escaped with |
||
|
||
\subparagraph[title]{[runtime] \textrightarrow [[\_\_NAME\_\_]] \textrightarrow [[[meta]]] \textrightarrow title} | ||
|
||
A single line description of this namespace. It is displayed by the | ||
\lstinline=cylc list= command and can be retrieved from running tasks | ||
|
@@ -1278,7 +1288,7 @@ \subsection{[runtime]} | |
\item {\em root default:} (none) | ||
\end{myitemize} | ||
|
||
\paragraph[description]{[runtime] \textrightarrow [[\_\_NAME\_\_]] \textrightarrow [[[meta]]] \textrightarrow description} | ||
\subparagraph[description]{[runtime] \textrightarrow [[\_\_NAME\_\_]] \textrightarrow [[[meta]]] \textrightarrow description} | ||
|
||
A multi-line description of this namespace, retrievable from running tasks with the | ||
\lstinline=cylc show= command. | ||
|
@@ -1288,7 +1298,7 @@ \subsection{[runtime]} | |
\item {\em root default:} (none) | ||
\end{myitemize} | ||
|
||
\paragraph[URL]{[runtime] \textrightarrow [[\_\_NAME\_\_]] \textrightarrow [[[meta]]] \textrightarrow URL} | ||
\subparagraph[URL]{[runtime] \textrightarrow [[\_\_NAME\_\_]] \textrightarrow [[[meta]]] \textrightarrow URL} | ||
\label{TaskURL} | ||
|
||
A web URL to task documentation for this suite. If present it can be browsed | ||
|
@@ -1314,7 +1324,7 @@ \subsection{[runtime]} | |
(Note that URLs containing the suite comment delimiter | ||
\lstinline=#= must be protected by quotes). | ||
|
||
\paragraph[\_\_MANY\_\_]{[runtime] \textrightarrow [[\_\_NAME\_\_]] \textrightarrow [[[meta]]] \textrightarrow \_\_MANY\_\_} | ||
\subparagraph[\_\_MANY\_\_]{[runtime] \textrightarrow [[\_\_NAME\_\_]] \textrightarrow [[[meta]]] \textrightarrow \_\_MANY\_\_} | ||
|
||
Replace \_\_MANY\_\_ with any user-defined metadata item. These, like title, URL, etc. can be passed | ||
to task event handlers to be interpreted according to your needs. For example, the value of an | ||
|
@@ -1624,13 +1634,13 @@ \subsection{[runtime]} | |
\item \%(message)s: event message, if any | ||
\end{myitemize} | ||
|
||
Can include the patterns from [[[meta]]] section of the task, for example: | ||
The template can also include the patterns from [[[meta]]] section of the task, for example: | ||
\begin{myitemize} | ||
\item \%(importance)s: task priority | ||
\item \%(color)s: task color | ||
\end{myitemize} | ||
|
||
Also able to include patterns from [meta] section of the suite, for example: | ||
Patterns from the [meta] section of the suite can also be used, for example: | ||
\begin{myitemize} | ||
\item \%(suite\_priority)s: suite priority | ||
\item \%(suite\_color)s: suite color | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quotes again here