-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HTTPS client host no domain issue #2432
Fix HTTPS client host no domain issue #2432
Conversation
Proper fix in cylc#2432.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I am not seeing the symptoms in #2422 any more
self._host = self._get_host_info()[0] | ||
return self._host | ||
|
||
def get_fqdn_by_host(self, target): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could fqdn
be replaced by a more verbose name (or at least an expansion of the abbreviation in the docstring)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fully qualified domain name is probably too long? And fqdn matches socket.getfqdn
, which is hopefully what this method is returning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could just go in the docstring then
The hostname as it appears in the title of the This fixes #2422 for me but I have found a new similar bug which can be repeated with these steps:
|
Yes I get this too - it is missing the domain name qualifier when gcylc is launched via gscan - it only prints the base hostname. |
(Should have gone for my original implementation, which would have eliminated all of these issues.) |
(Should now work?) |
Yep, the gcylc title outputs are matching now. @oliver-sanders bug looks to be fixed too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to all be working now.
Proper fix in cylc#2432.
0c95d43
to
5a8bb97
Compare
(Conflicts resolved.) |
Proper fix in cylc#2432.
@dvalters please do a final sanity check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comment.
A CLI specified host name with no domain part was causing the HTTPS client to fail because it is unable to match the host name in the SSL certificate (in which the host name has the domain name).
Reset GUI network client when suite is stopped. Create new client on reconnect.
5a8bb97
to
189639a
Compare
(All looking healthy again.) |
(1 final tweak. Waiting for test.) |
(Merge as all green with double review approval.) |
Proper fix in cylc#2432.
A CLI specified host name with no domain part was causing the HTTPS
client to fail because it is unable to match the host name in the SSL
certificate (in which the host name has the domain name).
Rename
cylc.suite_host
tocylc.hostuserutil
(as the module is now a generic utility for working with hosts and users).Should fix #2422.