check-software: fix undefined variable traceback #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Ignore open/close of PR made by mistake). |
sadielbartholomew
force-pushed
the
check-software-pymodule
branch
from
ef4c199
to
2754b78
Compare
sadielbartholomew
force-pushed
the
check-software-pymodule
branch
from
2754b78
to
1a2149d
Compare
oliver-sanders
approved these changes
May 29, 2018
|
A user hit this bug today, due to not have |
|
(PR needed to 'next maintenance release' too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another bug has been found in
check-software. When a Python module import fails within thecheck_py_module_ver()function,module_versiondoes not get defined, leading to a traceback when trying to compare that variable with the (un)specified minimum version & report the result.