Support symlinked alternate run directories (cylc 7). #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
changed the title
matthewrmshin
approved these changes
Jul 4, 2019
Conflicts: bin/cylc-register lib/cylc/suite_srv_files_mgr.py
hjoliver
force-pushed
the
alt-run-dir-take-2-7.8.x
branch
from
36ea271
to
6461f5d
Compare
|
I've finally finished this off. Ready for a quick second review (any volunteers?). See explanation in description of #2935. |
|
@wxtim please review 2. |
|
Back-ported registration test fixes #2935 (comment) |
wxtim
approved these changes
Aug 30, 2019
|
|
||
| CYLC_RUN_DIR="$(cylc get-global-config --print-run-dir)" | ||
|
|
||
| function make_rnd_suite() { |
There was a problem hiding this comment.
I know that at the moment this is the only place this is used, but might these functions be better in test_header?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.8.x back-port of #2935
Addresses #2797.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.md.