-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Cylc Review to access Cylc 8 Workflow data. #4134
Allow Cylc Review to access Cylc 8 Workflow data. #4134
Conversation
Fix access to task jobs list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming it has at least been tested manually
I'm not convinced that it's going to be particularly straightforward to automate a test for this. I think to test it manually that you should:
|
@dpmatthews said it worked for him on a quick test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have played a cylc 8 workflow and tested cylc review both fails on master and works as expected on this branch.
Thanks for getting me up and running with this @wxtim.
I have sent you a quick pm with the extra files from the cylc-install work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just need to test...
Tested, everything working as expected. |
These changes partially address #4113 - Depending upon discussion on that issue, this may be a complete solution.
cylc.flow
file. Modified the list of files so that this can be a 1-stop-shop.cylc-review
don't break differently to target branch. 😢Create a formal test that Cylc8 Workflows can be read.Manual testing only because this a complex test for legacy software.CONTRIBUTING.md
and added my name as a Code Contributor.