Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack-y fix of failure to show log files with + in title #4276

Merged
merged 5 commits into from
Jun 22, 2021
Merged

Hack-y fix of failure to show log files with + in title #4276

merged 5 commits into from
Jun 22, 2021

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jun 21, 2021 •
edited
Loading

These changes address #4260

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and conda-environment.yml.
  • Reviewer testing only.
  • Small changes to be summarized on closure of Review: Small Bugs Meta Issue #4261
  • No documentation update required.

I think that the problem is actually being caused by a problem in the HTML/JS - the + looks like it may be missing from the get command.

(3 Reviewers Tagged. 2nd can merge)

@wxtim wxtim self-assigned this Jun 21, 2021
@wxtim wxtim requested review from datamel and MetRonnie June 21, 2021 14:41
@wxtim wxtim mentioned this pull request Jun 21, 2021
Closed
4 tasks
@wxtim wxtim added this to the cylc-7.8.x milestone Jun 21, 2021
hjoliver
hjoliver reviewed Jun 21, 2021
View reviewed changes
lib/cylc/review.py Outdated Show resolved Hide resolved
hjoliver
hjoliver reviewed Jun 21, 2021
View reviewed changes
lib/cylc/review.py Outdated Show resolved Hide resolved
@wxtim
replace findall with search
1fb7295
@wxtim
replace findall with search
4a1787d
@wxtim
Merge branch 'cylc-review-fixes.fix-loss-of-plus-sign' of github.com:…
f7d89b2 
…wxtim/cylc into cylc-review-fixes.fix-loss-of-plus-sign

* 'cylc-review-fixes.fix-loss-of-plus-sign' of github.com:wxtim/cylc:
  replace findall with search
@wxtim wxtim requested a review from hjoliver June 22, 2021 06:32
MetRonnie
MetRonnie reviewed Jun 22, 2021
View reviewed changes
lib/cylc/review.py Outdated Show resolved Hide resolved
@wxtim @MetRonnie
Update lib/cylc/review.py
4001c60 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim wxtim requested a review from MetRonnie June 22, 2021 09:38
MetRonnie
MetRonnie approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with timezones +01, +0430 and -03, all work

hjoliver
hjoliver approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hjoliver hjoliver merged commit d3a0a4b into cylc:7.8.x Jun 22, 2021
@MetRonnie MetRonnie linked an issue Jun 28, 2021 that may be closed by this pull request
Review: Not showing files ending +ZZ (a timezone) #4260
Closed
@MetRonnie MetRonnie mentioned this pull request Jun 28, 2021
Closed
@wxtim wxtim deleted the cylc-review-fixes.fix-loss-of-plus-sign branch March 22, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@MetRonnie MetRonnie MetRonnie approved these changes

@datamel datamel Awaiting requested review from datamel

Assignees

@wxtim wxtim

Labels
None yet
Projects
None yet
Milestone
cylc-7.8.9 and 7.9.4
Development

Successfully merging this pull request may close these issues.

Review: Not showing files ending +ZZ (a timezone)
3 participants
@wxtim @hjoliver @MetRonnie