Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cylc review.cylc 8 file checks #4429

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Cylc review.cylc 8 file checks #4429

merged 3 commits into from
Sep 27, 2021

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Sep 23, 2021 •
edited
Loading

These changes close #4428
Reqires #4430 to be merged.

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Manual testing of legacy software.
  • Appropriate change log entry included.
  • No documentation update required.

@wxtim wxtim self-assigned this Sep 23, 2021
@wxtim wxtim marked this pull request as draft September 23, 2021 09:35
@oliver-sanders oliver-sanders changed the base branch from master to 7.8.x September 23, 2021 12:58
@wxtim wxtim marked this pull request as ready for review September 23, 2021 15:38
@wxtim wxtim requested review from datamel and removed request for dpmatthews September 23, 2021 16:09
hjoliver
hjoliver approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as working 👍

datamel
datamel approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this change. Thanks @wxtim!

@datamel datamel merged commit d7d2dcd into cylc:7.8.x Sep 27, 2021
@wxtim wxtim deleted the cylc-review.cylc-8-file-checks branch September 27, 2021 10:50
@hjoliver hjoliver mentioned this pull request Sep 30, 2021
Closed
@hjoliver hjoliver added this to the cylc-7.9.5 and 7.8.10 milestone Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@datamel datamel datamel approved these changes

Assignees

@wxtim wxtim

Labels
None yet
Projects
None yet
Milestone
cylc-7.9.5 and 7.8.10
Development

Successfully merging this pull request may close these issues.
3 participants
@wxtim @hjoliver @datamel